Patches item #865661, was opened at 2003-12-25 12:35 Message generated for change (Comment added) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=865661&group_id=103 Category: internationalization Group: Mailman 2.1 Status: Closed Resolution: Accepted Priority: 9 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: Collection of i18n patches Initial Comment: This patch works for 1. _at_ substitution for archive. 2. MIME decoded subject and message body in admindb pending post list. 3. i18n personalization. 4. Header/Footer charset adjusting for multiple charset. (works for Latin-15/1 problem, I believe.) 5. i18n message held notice. 6. fix for scrubber bug (atatched message). 7. i18n checkdbs. This collection of patch is for most recent CVS (2.1.4b) as of 12/25/2003 and I hope this is included in 2.1.4-release. ----------------------------------------------------------------------
Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-12-27 08:02
Message: Logged In: YES user_id=67709 Thank you and OK, Barry. I have submitted a new patch for Scrubber.py which is more descriptive about the problem, I believe. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-12-27 00:58 Message: Logged In: YES user_id=12800 I have applied all but the Decorate.py chunk and the Scrubber.py chunk. For Scrubber, please answer the questions below. For Decorate, I'm a little uncomfortable with apply this big of a patch so late in the game. My suggestion would be to split the remaining two patches up into separate (new) SF tracker items. I'm closing this one. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-12-26 22:47 Message: Logged In: YES user_id=12800 The Utils.py patch to include oneline() had some problems: - it didn't import email.Header or define UEMPTYSTRING - it shouldn't use oneline as a local var if the function is called oneline Both are fixable. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-12-26 20:47 Message: Logged In: YES user_id=12800 In Scrubber.py, can you explain more why this part is there: + # TK: We (Japanese) need to stringify and re-generate the message + # instance because multiple charsets are used. + try: + msg = message_from_string(str(msg)) + except UnicodeError: + pass IOW, why do you need to stringify and then re-parse the message? Can you provide an example message that this fixes? ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-12-26 18:36 Message: Logged In: YES user_id=12800 See attached Encoders.py-for-py234.txt for a patch to Encoders.py that doesn't break the Python 2.3.x test suite. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-12-26 18:23 Message: Logged In: YES user_id=12800 Okay, I see the patches to email/Charset.py and email/Encoders.py. I think I understand the fix to Encoders.py, but not really the fix to Charset.py. Could you explain in more detail? Also, please provide test cases for these changes. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-12-26 17:00 Message: Logged In: YES user_id=12800 Can you explain more what you mean by: "You may need patch email package to properly encode plain text with base64. (And others for Japanese messages)" ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-12-26 07:23 Message: Logged In: YES user_id=67709 Sorry but CJKCodecs was too big to upload in this patch area. You can download it from http://mm.tkikuchi.net/CJKCodecs-1.0.tar.gz Cheers, ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-12-26 07:20 Message: Logged In: YES user_id=67709 You may need patch email package to properly encode plain text with base64. (And others for Japanese messages) ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-12-26 07:16 Message: Logged In: YES user_id=67709 u Uploading CJKCodecs 1.0 because their site has only CVS and no package to download. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-12-26 07:11 Message: Logged In: YES user_id=67709 Update of patch. espacially: 1. improve in 4 above 2. Use of CJKCodecs instead of Japanese and Korean. Now we can use Chinese. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=865661&group_id=103