Bugs item #1181161, was opened at 2005-04-11 17:54 Message generated for change (Comment added) made by msapiro You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1181161&group_id=103 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: mail delivery Group: 2.1 beta Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Jim Tittsler (jtittsler) Assigned to: Nobody/Anonymous (nobody) Summary: Approved: only removed from text/plain part Initial Comment: If someone uses the "Approved: in the first line of the message" scheme, the line including the list password is only removed from the first text/plain part. It might be better to iterate over all text/* parts. ----------------------------------------------------------------------

Comment By: Mark Sapiro (msapiro) Date: 2007-06-09 13:03

Message: Logged In: YES user_id=1123998 Originator: NO The fix in 2.1.7 sometimes failed because it didn't decode quoted-printable and base64 encoded body parts. The fix has now been enhanced to decode the body part before looking for an Approve(d): line. This also fixes a related issue of not finding Approve(d): line in the first text/plain part or getting the password wrong if that part was encoded. The fix is in SVN (Mailman/Handlers/Approve.py). ---------------------------------------------------------------------- Comment By: Mark Sapiro (msapiro) Date: 2005-12-20 19:08 Message: Logged In: YES user_id=1123998 Fixed in CVS for 2.1.7rc1 and 2.2. We still require the Approve(d): <password> to be the first non-blank line in the first text/plain part (if it's not an actual header), but once it's found in the first text/plain part, we remove it from every text/* part in which we can find it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1181161&group_id=103