[Merge] lp:~mss/mailman/3.0-smtp-log-fix into lp:mailman
Malte S. Stretz has proposed merging lp:~mss/mailman/3.0-smtp-log-fix into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~mss/mailman/3.0-smtp-log-fix/+merge/55760 Trivial change: mailman.mta.base did log non-existent Message-Ids as None instead of n/a like .delivers does. -- https://code.launchpad.net/~mss/mailman/3.0-smtp-log-fix/+merge/55760 Your team Mailman Coders is requested to review the proposed merge of lp:~mss/mailman/3.0-smtp-log-fix into lp:mailman.
Thanks for the patch. I'm going to try to write a test for this, but can you tell me in what situation you're seeing the None's? Having a Message-ID header should be a requirement once the message is in the system, so if there are entry points which don't ensure that header, it might be better (or at least *also*) to fix that. -- https://code.launchpad.net/~mss/mailman/3.0-smtp-log-fix/+merge/55760 Your team Mailman Coders is requested to review the proposed merge of lp:~mss/mailman/3.0-smtp-log-fix into lp:mailman.
I just tested mailman by speaking via netcat to the LMTP port. And I was too lazy to type a Message-Id header. I think it should be fine to refuse the mail if there Message-Id header is missing (the mda should have added one already). -- https://code.launchpad.net/~mss/mailman/3.0-smtp-log-fix/+merge/55760 Your team Mailman Coders is requested to review the proposed merge of lp:~mss/mailman/3.0-smtp-log-fix into lp:mailman.
participants (2)
-
Barry Warsaw -
Malte S. Stretz