[Merge] lp:~sophron/postorius/create_users into lp:postorius
George Chatzisofroniou has proposed merging lp:~sophron/postorius/create_users into lp:postorius. Requested reviews: Florian Fuchs (flo-fuchs) For more details, see: https://code.launchpad.net/~sophron/postorius/create_users/+merge/129567 I worked on this bug: https://bugs.launchpad.net/postorius/+bug/1058445 I added the feature to create a mailman user account, but in order to edit the basic user data via the web interface, some additions to mailman client are required. See, https://bugs.launchpad.net/mailman.client/+bug/1066352 and https://bugs.launchpad.net/mailman.client/+bug/1066343. We also need an icon for the new entry on the menu: https://bugs.launchpad.net/postorius/+bug/1066340 I think it's better to divide the whole 'edit user' feature into smaller ones (delete user, register addresses to a user, basic data edit, etc). -- https://code.launchpad.net/~sophron/postorius/create_users/+merge/129567 Your team Mailman Coders is subscribed to branch lp:postorius.
Review: Approve Hi George, thank you for your changes (and the bug reports)! I have just merged them to the trunk. I only made some very small changes and additions (adjusted the docstring in MailmanUserView, added the user icon, some PEP8 fixes...). I also made the user list and details only available to superusers (I don't think every user should be able to see who else is there...). So now that we have a method to add new users to the core, we need a way to connect them to the users in the postorius database (the ones added through django.contrib.auth). I added some comment about that in the bug description: https://bugs.launchpad.net/postorius/+bug/1058445 Cheers and thanks again Florian -- https://code.launchpad.net/~sophron/postorius/create_users/+merge/129567 Your team Mailman Coders is subscribed to branch lp:postorius.
Isn't the visibility of the list members a per_list policy setting? In any case, we will need to have list administrators (who are not the superuser) be able to see the membership on their list. I think that Postorius will require a better model for roles. Richard On Oct 25, 2012, at 3:19 AM, Florian Fuchs <flo.fuchs@gmail.com> wrote:
Review: Approve
Hi George,
thank you for your changes (and the bug reports)! I have just merged them to the trunk. I only made some very small changes and additions (adjusted the docstring in MailmanUserView, added the user icon, some PEP8 fixes...). I also made the user list and details only available to superusers (I don't think every user should be able to see who else is there...).
-- https://code.launchpad.net/~sophron/postorius/create_users/+merge/129567 Your team Mailman Coders is subscribed to branch lp:postorius.
Hi Richard, 2012/10/25 Richard Wackerbarth <richard@nfsnet.org>:
Isn't the visibility of the list members a per_list policy setting?
Please not that users/index is not a list of members, but a list of the users stored in Mailman's core database. The members of a list are displayed for each list separately and can be accessed only by superusers and list owners.
In any case, we will need to have list administrators (who are not the superuser) be able to see the membership on their list.
I think that Postorius will require a better model for roles.
Yes, this is already possible. There are two custom permission decorators for view functions (list_owner_required and list_moderator_required) that check if the currently logged-in user is either the owner or the moderator of a list. Currently those restrictions are in user on the list members page, the moderation page, the list settings etc. Next step is providing forms to make existing users owners and/or moderators. Cheers Florian -- https://code.launchpad.net/~sophron/postorius/create_users/+merge/129567 Your team Mailman Coders is subscribed to branch lp:postorius.
The proposal to merge lp:~sophron/postorius/create_users into lp:postorius has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~sophron/postorius/create_users/+merge/129567 -- https://code.launchpad.net/~sophron/postorius/create_users/+merge/129567 Your team Mailman Coders is subscribed to branch lp:postorius.
participants (4)
-
Florian Fuchs -
George Chatzisofroniou -
noreply＠launchpad.net -
Richard Wackerbarth