[Bug 1203359] [NEW] IArchiver.archive_message implementations return None
Public bug reported: The Interface sez: def archive_message(mlist, msg): """Send the message to the archiver. :param mlist: The IMailingList object. :param msg: The message object. :returns: The url string or None if the message's archive url cannot be calculated. """ but none of prototype, MHonArch, and mailarchive return anything. I think the Interface should be changed to say ":returns: None". ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1203359 Title: IArchiver.archive_message implementations return None To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1203359/+subscriptions
can you explain this to me in a little detail. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1203359 Title: IArchiver.archive_message implementations return None To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1203359/+subscriptions
While the built-in archivers do currently return None, it is possible that more information can be provided about the archived message. That's why the interface leaves it open to return the archive url if available. It's possible MHonArc could be made to do this; contributions welcome. It's possible the prototype archiver could do this as well. Happy to take a contribution for this too. For now, the interface is right, but the existing IArchiver implementations should be explicit in their return of None. We don't want to rely on Python's implicit return of None. I'll make that fix. ** Tags added: mailman3 ** Changed in: mailman Milestone: None => 3.0.0b6 ** Changed in: mailman Status: New => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1203359 Title: IArchiver.archive_message implementations return None To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1203359/+subscriptions
** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1203359 Title: IArchiver.archive_message implementations return None To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1203359/+subscriptions
participants (3)
-
Barry Warsaw -
Saprative -
Stephen Turnbull