[Merge] lp:~ralfjung-e/mailman/2.1 into lp:mailman/2.1

Ralf Jung has proposed merging lp:~ralfjung-e/mailman/2.1 into lp:mailman/2.1. Commit message: Implement a simple CAPTCHA scheme based on questions and answers configured by the site admin. Fixes https://bugs.launchpad.net/mailman/+bug/1774826. I have manually edited listinfo.html for a few languages for testing; is there a way to automate that or do I have to manually do that for all languages? Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~ralfjung-e/mailman/2.1/+merge/368614 -- Your team Mailman Coders is requested to review the proposed merge of lp:~ralfjung-e/mailman/2.1 into lp:mailman/2.1.

I like this solution, it's simple and easily customizable, doesn't rely on 3rd-party integrations, and the CAPTCHA questions can be easily updated. Nice work Ralf. One thing that I would like to see in the future is storing the CAPTCHAs in pck or even sql, etc. -- https://code.launchpad.net/~ralfjung-e/mailman/2.1/+merge/368614 Your team Mailman Coders is requested to review the proposed merge of lp:~ralfjung-e/mailman/2.1 into lp:mailman/2.1.

Thanks for this. I am currently traveling and I will review it in detail as I have time. -- https://code.launchpad.net/~ralfjung-e/mailman/2.1/+merge/368614 Your team Mailman Coders is requested to review the proposed merge of lp:~ralfjung-e/mailman/2.1 into lp:mailman/2.1.

If line 20 (in the patch below) sets "captcha_idx = 0" python throws an error: TypeError: cannot concatenate 'str' and 'int' objects I think a better solution would be to remove the captcha_idx from that section of code if it is None, (and set it to None at line 20). -- https://code.launchpad.net/~ralfjung-e/mailman/2.1/+merge/368614 Your team Mailman Coders is requested to review the proposed merge of lp:~ralfjung-e/mailman/2.1 into lp:mailman/2.1.

Ah good catch, I forgot to test this without CAPTCHAS set. However, the variable is used later to compute the hash for the form secret. Removing it conditionally will mean we have to mirror the same logic on the other side in subscribe.py. So for now I changed it to use the empty string instead. I don't know if this will automatically get included in this MR? -- https://code.launchpad.net/~ralfjung-e/mailman/2.1/+merge/368614 Your team Mailman Coders is requested to review the proposed merge of lp:~ralfjung-e/mailman/2.1 into lp:mailman/2.1.

The recent change will be included in the MR, you can confirm this by looking at the diff down below these comments on webform for the MR. -- https://code.launchpad.net/~ralfjung-e/mailman/2.1/+merge/368614 Your team Mailman Coders is requested to review the proposed merge of lp:~ralfjung-e/mailman/2.1 into lp:mailman/2.1.

The proposal to merge lp:~ralfjung-e/mailman/2.1 into lp:mailman/2.1 has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~ralfjung-e/mailman/2.1/+merge/368614 -- Your team Mailman Coders is requested to review the proposed merge of lp:~ralfjung-e/mailman/2.1 into lp:mailman/2.1.
participants (4)
-
Jim Popovitch
-
Mark Sapiro
-
noreply@launchpad.net
-
Ralf Jung