[Bug 1165589] [NEW] Switchboard fails to log the error message with some exceptions.
Public bug reported: The Switchboard.finish() method logs an error when attempting to preserve or unlink the .bak file throws an EnvironmentError exception, but the actual error message from the exception isn't logged. This missing information can be quite helpful. ** Affects: mailman Importance: Medium Assignee: Mark Sapiro (msapiro) Status: In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions
** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions
** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions
Added MM3 bug task as this would be nice to get into 3.x also. ** Tags added: mailman3 ** Also affects: mailman/2.1 Importance: Undecided Status: New ** Also affects: mailman/3.0 Importance: Medium Assignee: Mark Sapiro (msapiro) Status: Fix Committed ** Changed in: mailman/2.1 Status: New => Fix Committed ** Changed in: mailman/2.1 Importance: Undecided => Medium ** Changed in: mailman/2.1 Assignee: (unassigned) => Mark Sapiro (msapiro) ** Changed in: mailman/2.1 Milestone: None => 2.1.16 ** Changed in: mailman/3.0 Status: Fix Committed => Triaged ** Changed in: mailman/3.0 Importance: Medium => Low ** Changed in: mailman/3.0 Assignee: Mark Sapiro (msapiro) => (unassigned) ** Changed in: mailman/3.0 Milestone: 2.1.16 => None -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions
** Branch linked: lp:~mgill25/mailman/branch2 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions
** Changed in: mailman/2.1 Status: Fix Committed => Fix Released ** Changed in: mailman/2.1 Milestone: 2.1.16 => 2.1.16rc1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions
Hi, I fixed the bug,ran the tests and its working fine on my syatem.Please review ** Patch added: ".diff file for switchboard.py" https://bugs.launchpad.net/mailman/+bug/1165589/+attachment/4316481/+files/s... -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions
** Changed in: mailman/3.0 Assignee: (unassigned) => Rashi Karanpuria (rashi007) ** Branch linked: lp:~rashi007/mailman/mailman ** Changed in: mailman/3.0 Status: Triaged => Fix Committed ** Changed in: mailman/3.0 Status: Fix Committed => In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions
** Branch linked: lp:~rashi007/mailman/rashi -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions
Actually, as it turns out, this bug does not affect Mailman 3. The error is logged with .exception() which includes the full traceback. I just wrote a test to confirm this. ** Changed in: mailman/3.0 Status: In Progress => Invalid -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions
participants (5)
-
Barry Warsaw -
Launchpad Bug Tracker
-
Manish Gill -
Mark Sapiro -
Rashi Karanpuria