[Merge] lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman

Stephen A. Goss has proposed merging lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #833132 in GNU Mailman: "Unable to query or change member delivery_mode through REST API." https://bugs.launchpad.net/mailman/+bug/833132 Bug #833376 in GNU Mailman: "Attempting to PATCH an invalid attribute on a member object in REST API results in 500, instead of 400." https://bugs.launchpad.net/mailman/+bug/833376 For more details, see: https://code.launchpad.net/~postfuturist/mailman/rest-api-delivery_mode/+mer... Currently, in the REST API for members/subscriptions you can create a subscription with a specific delivery_mode (regular or various digest modes). However, you can't get this information back from the REST API or change it. This branch addresses these shortcomings by adding delivery_mode to the information returned by the API when GETing member info, it also allows you to PATCH the delivery_mode of a member. It handles edge/error cases, like patching nonexistent members, patching invalid parameters, etc. All cases are tested (I think). This resolves 833132 and 833376. -- https://code.launchpad.net/~postfuturist/mailman/rest-api-delivery_mode/+mer... Your team Mailman Coders is requested to review the proposed merge of lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman.

Thanks for the branch! It's generally better to provide separate branches for each of the separate bugs though, otherwise it's more difficult to review and apply. In this case, no worries, I'll work it out. -- https://code.launchpad.net/~postfuturist/mailman/rest-api-delivery_mode/+mer... Your team Mailman Coders is requested to review the proposed merge of lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman.

Oh, one thing I'm going to remove is the prohibition against PATCHing with no attributes. I think that should be fine (and the member won't change). -- https://code.launchpad.net/~postfuturist/mailman/rest-api-delivery_mode/+mer... Your team Mailman Coders is requested to review the proposed merge of lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman.

The proposal to merge lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~postfuturist/mailman/rest-api-delivery_mode/+mer... -- https://code.launchpad.net/~postfuturist/mailman/rest-api-delivery_mode/+mer... Your team Mailman Coders is requested to review the proposed merge of lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman.
participants (3)
-
Barry Warsaw
-
noreply@launchpad.net
-
Stephen A. Goss