[Merge] lp:~bhavesh-goyal093/postorius/postorius-page-titles into lp:postorius
Bhavesh Goyal has proposed merging lp:~bhavesh-goyal093/postorius/postorius-page-titles into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~bhavesh-goyal093/postorius/postorius-page-titles... Fixed Bug #1443658. Earlier Postorius Pages had no fixed titles for specific pages and all the pages used to inherit a default blank title. Now, a relevant title for each of the pages in postorius has been added which now makes it easier to differentiate between multiple pages opened simultaneously in the browser. -- Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/postorius/postorius-page-titles into lp:postorius.
This is looking pretty good. Can you double-check that these strings are grabbed correctly for translation by the django tools? https://docs.djangoproject.com/en/1.8/topics/i18n/translation/ -- https://code.launchpad.net/~bhavesh-goyal093/postorius/postorius-page-titles... Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/postorius/postorius-page-titles into lp:postorius.
Review: Needs Fixing Also, I think we probably want to put " - Mailman/Postorius" as a suffix on all the titles, for consistency and to make it easier for people searching through their history/bookmarks to find related pages. It's easier to remove this later than it would be to add it later, anyhow. -- https://code.launchpad.net/~bhavesh-goyal093/postorius/postorius-page-titles... Your team Mailman Coders is subscribed to branch lp:postorius.
Hi Terri ! Thanks for the review :) I 'll add translation tags to the strings and the suffixes to all titles and give you an update when its done then -- https://code.launchpad.net/~bhavesh-goyal093/postorius/postorius-page-titles... Your team Mailman Coders is subscribed to branch lp:postorius.
The proposal to merge lp:~bhavesh-goyal093/postorius/postorius-page-titles into lp:postorius has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~bhavesh-goyal093/postorius/postorius-page-titles... -- Your team Mailman Coders is subscribed to branch lp:postorius.
Review: Approve -- https://code.launchpad.net/~bhavesh-goyal093/postorius/postorius-page-titles... Your team Mailman Coders is subscribed to branch lp:postorius.
participants (3)
-
Bhavesh Goyal -
noreply＠launchpad.net -
Terri