Bugs item #1020013, was opened at 2004-08-31 21:10 Message generated for change (Comment added) made by ams001 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1020013&group_id=103 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Web/CGI Group: 2.1 (stable) Status: Closed Resolution: None Priority: 5 Submitted By: John Dennis (johndennis) Assigned to: Nobody/Anonymous (nobody) Summary: spam filters get removed when changing other privacy pages Initial Comment: This was filed in the Red Hat bugzilla as: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=130479 Promoting to upstream Summary is: If you enter some header_filter_rules in the mailman admin pages (Privacy->Spam filters) and click "submit" they are added to the list configuration database. However, if you now go to one of the other Privacy pages and click "submit" and return to the Spam Filters page, you'll find that your header_filter_rules settings have been removed. This appears to be caused by the handleForm function in ~mailman/Mailman/Gui/Privacy.py not checking to see which subsection is being submitted before processing the data for and setting the mlist.header_filter_rules list configuration variable. Version-Release number of selected component (if applicable): mailman-2.1.5 How reproducible: Always Steps to Reproduce: 1. Create list. 2. Go to the Privacy->Spam filters page, add some header_filter_rules and hit submit. 3. Go to the Privacy->Sender filters page but don't hit submit 4. Go back to Spam filters and note that they're still present 5. Return to Sender filters and hit submit 6. Go back to Spam filters and note that they've been removed. Actual Results: All spam filters are removed. Expected Results: Spam filter settings should be retained. ---------------------------------------------------------------------- Comment By: Alex (ams001) Date: 2005-07-01 10:56 Message: Logged In: YES user_id=1156173 See 1230865 (http://sourceforge.net/tracker/index.php?func=detail&aid=1230865&group_id=103&atid=100103) for updated patch against v2.1.6 (http://sourceforge.net/tracker/download.php?group_id=103&atid=100103&file_id=140484&aid=1230865) ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2004-09-15 12:48 Message: Logged In: YES user_id=67709 Fixed in CVS Gui/Privacy.py Revision 2.15.2.4 ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2004-09-01 01:33 Message: Logged In: YES user_id=67709 a patch is uploaded (id 1020102) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1020013&group_id=103