Bugs item #1275856, was opened at 2005-08-29 10:26 Message generated for change (Comment added) made by msapiro You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1275856&group_id=103 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Web/CGI Group: 2.1 (stable)

Status: Closed Resolution: Fixed Priority: 5 Submitted By: Mark Sapiro (msapiro) Assigned to: Nobody/Anonymous (nobody) Summary: Utils.get_domain() wrong if VIRTUAL_HOST_OVERVIEW off

Initial Comment: Part of the code in get_domain() in Utils.py is: if mm_cfg.VIRTUAL_HOST_OVERVIEW and host: return host.lower() else: # See the note in Defaults.py concerning DEFAULT_HOST_NAME # vs. DEFAULT_EMAIL_HOST. hostname = mm_cfg.DEFAULT_HOST_NAME or mm_cfg.DEFAULT_EMAIL_HOST return hostname.lower() It is clear that get_domain() should return the web host, not the e-mail host. This code should be: if mm_cfg.VIRTUAL_HOST_OVERVIEW and host: return host.lower() else: # See the note in Defaults.py concerning DEFAULT_URL # vs. DEFAULT_URL_HOST. hostname = mm_cfg.DEFAULT_URL or mm_cfg.DEFAULT_URL_HOST return hostname.lower() ----------------------------------------------------------------------

Comment By: Mark Sapiro (msapiro) Date: 2006-03-12 10:11

Message: Logged In: YES user_id=1123998 Fixed in CVS for releases above 2.1.8a1. hostname = mm_cfg.DEFAULT_URL or mm_cfg.DEFAULT_URL_HOST is not the correct fix as DEFAULT_URL is a URL, not a domain, so I changed it to hostname = mm_cfg.DEFAULT_HOST_NAME or mm_cfg.DEFAULT_URL_HOST ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1275856&group_id=103