[Merge] lp:~crodjer/postorius/postorius into lp:postorius
Rohan Jain has proposed merging lp:~crodjer/postorius/postorius into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~crodjer/postorius/postorius/+merge/99881 These let the Web UI work with django 1.4 by handling changes which were there in 1.2 but are dropped from 1.4. They also do not break anything and should work fine with django 1.2/1.3 -- https://code.launchpad.net/~crodjer/postorius/postorius/+merge/99881 Your team Mailman Coders is requested to review the proposed merge of lp:~crodjer/postorius/postorius into lp:postorius.
The proposal to merge lp:~crodjer/postorius/postorius into lp:postorius has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~crodjer/postorius/postorius/+merge/99881 -- https://code.launchpad.net/~crodjer/postorius/postorius/+merge/99881 Your team Mailman Coders is subscribed to branch lp:postorius.
Review: Approve Hello Rohan, thank you for this fix! I just merged it into the trunk. Only thing: I renamed mutest.db to mmtest.db in dev_setup/settings.py again. Florian -- https://code.launchpad.net/~crodjer/postorius/postorius/+merge/99881 Your team Mailman Coders is subscribed to branch lp:postorius.
Okay. I changed it to mutest.db because someone by the nick wacky asked over the IRC -- Rohan On Thursday, April 5, 2012, Florian Fuchs wrote:
Review: Approve
Hello Rohan,
thank you for this fix! I just merged it into the trunk. Only thing: I renamed mutest.db to mmtest.db in dev_setup/settings.py again.
Florian
-- https://code.launchpad.net/~crodjer/postorius/postorius/+merge/99881 You are the owner of lp:~crodjer/postorius/postorius.
-- Rohan Jain https://code.launchpad.net/~crodjer/postorius/postorius/+merge/99881 Your team Mailman Coders is subscribed to branch lp:postorius.
On Apr 4, 2012, at 9:40 PM, Rohan Jain wrote:
Okay. I changed it to mutest.db because someone by the nick wacky asked over the IRC
First, that was a typo in my IRC message. Second, I did not request that you change the file name. I ASK why you changed the definition (from Florian's computed path). You never responded. -- https://code.launchpad.net/~crodjer/postorius/postorius/+merge/99881 Your team Mailman Coders is subscribed to branch lp:postorius.
I am sorry about not responding right away. I was away from the computer then. I did respond much later though. I'll blame this to the time zones. --Rohan On 04:01 -0000 / 5 Apr, Richard Wackerbarth wrote:
On Apr 4, 2012, at 9:40 PM, Rohan Jain wrote:
Okay. I changed it to mutest.db because someone by the nick wacky asked over the IRC
First, that was a typo in my IRC message. Second, I did not request that you change the file name. I ASK why you changed the definition (from Florian's computed path). You never responded. -- https://code.launchpad.net/~crodjer/postorius/postorius/+merge/99881 You are the owner of lp:~crodjer/postorius/postorius.
-- https://code.launchpad.net/~crodjer/postorius/postorius/+merge/99881 Your team Mailman Coders is subscribed to branch lp:postorius.
participants (4)
-
Florian Fuchs -
noreply＠launchpad.net -
Richard Wackerbarth -
Rohan Jain