[Bug 1161445] [NEW] Localization issue with 'remove_members' and possible fix
Public bug reported: Hello, I found a language issue that I was able to fix. My installation of Mailman 2.1.13 (Debian Squeeze) uses German localization, DEFAULT_SERVER_LANGUAGE is set to 'de'. The issue: When I remove a member from the commandline with 'remove_members <list> <address>', the mail to the user 'You have been unsubscribed from the <list> mailing list' has an unlocalized subject line. This does not happen using the email interface. Obviously the user language setting for i18n has not been done when this mail subject string gets localized. I inserted one line into Deliverer.py which fixed the issue for me: File: Deliverer.py - near line 84 ... def SendUnsubscribeAck(self, addr, lang): realname = self.real_name + i18n.set_language(lang) msg = Message.UserNotification( self.GetMemberAdminEmail(addr), self.GetBouncesEmail(), _('You have been unsubscribed from the %(realname)s mailing list'), Utils.wrap(self.goodbye_msg), lang) msg.send(self, verp=mm_cfg.VERP_PERSONALIZED_DELIVERIES) ... Could someone knowledgeable please review this as I am not sure that it is the proper fix for the issue? Regards Thomas ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1161445 Title: Localization issue with 'remove_members' and possible fix To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1161445/+subscriptions
** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1161445 Title: Localization issue with 'remove_members' and possible fix To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1161445/+subscriptions
Thank you for the report and the suggested fix which is the right one. ** Changed in: mailman Importance: Undecided => Medium ** Changed in: mailman Status: New => Fix Committed ** Changed in: mailman Milestone: None => 2.1.16 ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1161445 Title: Localization issue with 'remove_members' and possible fix To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1161445/+subscriptions
** Changed in: mailman Status: Fix Committed => Fix Released ** Changed in: mailman Milestone: 2.1.16 => 2.1.16rc1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1161445 Title: Localization issue with 'remove_members' and possible fix To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1161445/+subscriptions
participants (3)
-
Launchpad Bug Tracker
-
Mark Sapiro
-
Thomas Baumann