Public bug reported:
The fix for https://bugs.launchpad.net/mailman/+bug/1859104 assumes that every entry in pending.pck is a 2-tuple, but this is wrong. The attached patch will fix this.
** Affects: mailman Importance: Medium Assignee: Mark Sapiro (msapiro) Status: In Progress
** Patch added: "Patch to fix this issue" https://bugs.launchpad.net/bugs/1878458/+attachment/5371019/+files/MailList....
** Branch linked: lp:mailman/2.1
What happens if v is 1-tuple and the patch references it in "v[1].address.lower()" ?
** Changed in: mailman Status: In Progress => Fix Committed
First of all, v is never a 1-tuple. It always is (op, *data), but even if it were a 1-tuple, op wouldn't be Pending.SUBSCRIPTION so we wouldn't look at v[1] anyway.
Thanks Mark!
The fix for this has been extended to apply REFUSE_SECOND_PENDING to unsubscription as well. See https://bazaar.launchpad.net/%7Emailman- coders/mailman/2.1/revision/1851
And yes, I know the error message says 'subscription'. This is intentional to not introduce a new i18n string.
** Changed in: mailman Status: Fix Committed => Fix Released
-
Jim Popovitch -
Launchpad Bug Tracker -
Mark Sapiro
-
Mark Sapiro