[Bug 1488656] [NEW] REMOVE_DKIM_HEADERS = 2, describe but not implemented

Public bug reported: In the debian package (Wheezy) and the tarball mailman-2.1.20: Default.py describes than REMOVE_DKIM_HEADERS = 2 should overwrite the from_is_list == 1. But this is not implemented in Handlers/CleanseDKIM.py . ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1488656 Title: REMOVE_DKIM_HEADERS = 2, describe but not implemented To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1488656/+subscriptions

** Changed in: mailman Status: New => Incomplete -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1488656 Title: REMOVE_DKIM_HEADERS = 2, describe but not implemented To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1488656/+subscriptions

I believe the code is correct and does what is documented in Defaults.py. If you disagree, please give specific examples of settings, what result they should produce and what they actually produce. In particular, if REMOVE_DKIM_HEADERS =2, the if not (mm_cfg.REMOVE_DKIM_HEADERS or mlist.anonymous_list): is false and doesn't return, and the second if (mm_cfg.REMOVE_DKIM_HEADERS == 1 and not ... is also false and does not return and the del statements are executed. I don't know what you mean by "REMOVE_DKIM_HEADERS = 2 should overwrite the from_is_list == 1." What the documentation says is if REMOVE_DKIM_HEADERS = 2, the headers are removed regardless of the from_is_list setting, and that's what's done. ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1488656 Title: REMOVE_DKIM_HEADERS = 2, describe but not implemented To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1488656/+subscriptions
participants (2)
-
Mark Sapiro
-
Simon