[Bug 937154] [NEW] bin/disabled.py is nonfunctional
Public bug reported: The bin/disabled.py script needs tests, documentation, and fixing in Mailman 2. ** Affects: mailman Importance: High Assignee: Barry Warsaw (barry) Status: Confirmed ** Tags: mailman3 ** Changed in: mailman Status: New => Confirmed ** Changed in: mailman Importance: Undecided => High ** Changed in: mailman Milestone: None => 3.0.0b1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/937154 Title: bin/disabled.py is nonfunctional To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/937154/+subscriptions
** Description changed: The bin/disabled.py script needs tests, documentation, and fixing in - Mailman 2. + Mailman 3. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/937154 Title: bin/disabled.py is nonfunctional To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/937154/+subscriptions
Oh yeah, it should also get moved into a subcommand of bin/mailman, i.e. cli_disable.py -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/937154 Title: bin/disabled.py is nonfunctional To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/937154/+subscriptions
** Changed in: mailman Milestone: 3.0.0b1 => postponed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/937154 Title: bin/disabled.py is nonfunctional To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/937154/+subscriptions
I can try to challenge this problem, only a couple of questions: - What options should the command have?? Should it provide exactly the same command line interface? - Does it need to be independent from the rest of the code or should it be added to the mailman commands?? Anything else that I should know? -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/937154 Title: bin/disabled.py is nonfunctional To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/937154/+subscriptions
On Mar 26, 2012, at 08:03 PM, Andrea Crotti wrote:
Should it provide exactly the same command line interface?
Not necessarily. Looking at the code now I think the long options are probably fine, but I'm not sure the short options are great (e.g. -o is usually reserved for output to a file; not relevant for this particular script, but I don't like appropriating commonly understood options if at all possible). Also --unknown won't be useful now; that was a nod to some bug in MM2.1 we never figured out. ;) If you make it a bin/mailman subcommand, you won't need to re-implement -C here.
- Does it need to be independent from the rest of the code or should it be added to the mailman commands??
I think I would make it a bin/mailman subcommand. One of the main use cases for this script is to implement a cron job that site admins can enable to process users in various statuses. But I think a cron could invoke a subcommand just fine. Still, that use case should inform its cli.
Anything else that I should know?
One thing to keep in mind is that in mm3, I'm trying to reduce the amount of logic in the actual commands. Meaning, it would be better to move as much as possible into core services, and have the command do as little as possible, over cli parsing and such.
** Changed in: mailman Milestone: postponed => None ** Changed in: mailman Assignee: Barry Warsaw (barry) => (unassigned) ** Changed in: mailman Importance: High => Low -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/937154 Title: bin/disabled.py is nonfunctional To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/937154/+subscriptions
I'm removing the 'easy' tag because updating this script is wrapped up in work I'm doing on the bounce processing subsystem. ** Tags removed: easy -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/937154 Title: bin/disabled.py is nonfunctional To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/937154/+subscriptions
This bug has been moved to the new gitlab repo here: https://gitlab.com/mailman/mailman/issues/34 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/937154 Title: bin/disabled.py is nonfunctional To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/937154/+subscriptions
participants (4)
-
Abhilash Raj -
Andrea Crotti -
Barry Warsaw
-
Barry Warsaw