[Bug 973790] [NEW] 'approved' rule should not modify the message
![](https://secure.gravatar.com/avatar/bfef56742016acb07a69144cbdee8da0.jpg?s=120&d=mm&r=g)
Public bug reported: In Mailman 3, technically rules should not have side effects. The 'approved' rule breaks this because it removes the Approved header (and other supported headers) from the message. There should instead be a handler that does the header cleaning, and the rule should not do this.
From an implementation standpoint, the same code can be used in both the handler and in the rule. You can use a slightly different API wrapper and use a flag to indicate whether the header should be removed or not. OTOH, some clever refactoring might make better sense.
** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/973790 Title: 'approved' rule should not modify the message To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/973790/+subscriptions
![](https://secure.gravatar.com/avatar/bfef56742016acb07a69144cbdee8da0.jpg?s=120&d=mm&r=g)
** Changed in: mailman Status: New => Confirmed ** Changed in: mailman Importance: Undecided => Low ** Changed in: mailman Milestone: None => postponed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/973790 Title: 'approved' rule should not modify the message To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/973790/+subscriptions
![](https://secure.gravatar.com/avatar/05009efa3bca152096ff27af62e69bfc.jpg?s=120&d=mm&r=g)
As far as I see, the cleanse handler removes the approved headers, too. I.e. whenever the message goes through the posting pipeline, the headers are removed. Should they get removed when the message goes through other pipelines, too? If not, I guess the removal code from the approved rule could just be deleted? -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/973790 Title: 'approved' rule should not modify the message To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/973790/+subscriptions
![](https://secure.gravatar.com/avatar/bfef56742016acb07a69144cbdee8da0.jpg?s=120&d=mm&r=g)
This bug has been moved to the new gitlab repo here: https://gitlab.com/mailman/mailman/issues/37 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/973790 Title: 'approved' rule should not modify the message To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/973790/+subscriptions
participants (3)
-
Abhilash Raj
-
Barry Warsaw
-
David Soto