On Aug 19, 2012, at 04:50 PM, Peter Holzer wrote:
In my opinion or at least for our usecase it doesn't make much sense to send 2 mails to the subscriber, one that tells the user "Confirmation email sent" and sending a mail to the user that he should confirm his email address. If the command is successful, at least when there is only one command executed, it should be enough to send the actual result of the command.
Would that be reasonable to make that configurable?
Yes, I think so.
Where would be the right place to hook in and at least prevent such "double" send outs?
The place to hook this in would be in the CommandRunner src/mailman/runners/command.py
If you look down near the bottom of _dispose(), you'll see where the reply is created from a UserNotification(), then at the very bottom, it's sent. The hypothetical flag controlling this would just skip all that to prevent the results from being sent.
The question is how controllable would this need to be? Presumably, the
IMailingList itself would have a flag turning this off,
e.g. send_command_results.
If you do end up taking a crack at this, please open a bug and attach a branch. Ideally, it would have a unittest or doctest, and it will have to go through a schema migration, but I can help with that.
One other thing, I think it would be nice to have the actual list name in the subject of the action mails, for example "MyMailinglist confirm 66c0886...." instead of confirm 66c0886...." and it wouldn't interfere with the actual commands being executed as far as i could test it. How about adding this to mailman3 core and where to add it?
This will also take some more elaborate processing in the eml_confirm.py command. I think there are enough hints in the confirmation message to know which mailing list it's coming from, but if not, please submit a separate bug on this (and a separate branch if you work on a fix).
Cheers, -Barry