On Sun, 2006-04-23 at 08:30 +0900, Tokio Kikuchi wrote:
I had some hours playing with the new svn trunk. (I was a little bit busy because our academic year begins April.)
bwarsaw@users.sourceforge.net wrote:
Revision: 7858 Author: bwarsaw Date: 2006-04-16 21:08:17 -0700 (Sun, 16 Apr 2006) ViewCVS: http://svn.sourceforge.net/mailman/?rev=7858&view=rev
Log Message:
- Convert all logging to Python's standard logging module. Get rid of all traces of our crufty old Syslog. Most of this work was purely mechanical, except for:
I get this for a fresh install of svn trunk. You may have old install remained, if you haven't experienced this.
% bin/mailmanctl start Traceback (most recent call last): File "bin/mailmanctl", line 112, in ? from Mailman.Logging.Syslog import syslog ImportError: No module named Logging.Syslog
Try r7871. I think I've fixed this now.
Also, if you send SIGHUP to reopen the logs, only the last reopen messages is recorded because each runners try to reopen the log file. We may have to restart qrunners if mailmanctl receive SIGHUP and it has started new log files. We may also utilize the backupCount feature for log rotation (intruducing LOG_BACKUP_COUNT in Defaults.py).
I decided not to use the RotatingFileHandler and leave file rotation to external tools like logrotate. Instead I implemented a subclass of FileHandler that allows for reopening the log files (I wonder why this isn't part of the base FileHandler).
One thing we may have to do though is set the log file encoding. What do you think about that?
-Barry