On Jan 1, 2006, at 13:51, Brad Knowles wrote:
At 3:48 AM -0500 2006-01-01, Robby Griffin wrote:
Here's what I've done for somewhat unrelated reasons:
patch bin/discard to support rejecting held messages and providing rejection comments.
add a cron job that rejects held messages older than 10 days, with the following comment:
"Your message was automatically rejected after being on hold too long without moderator action."
I like both of these modifications. Have you already submitted patches for them to SourceForge? If not, could I talk you into doing that?
I'll go ahead and post what I have as it relates to 2.1.4, and point out that held message expiration in 2.1.7 already exists but could use minor improvements.
I don't have a lot of time to work on it right now, and as I started to think about putting together clean diffs against 2.1.7, I observed that my changes are *almost* obsolete: sometime after 2.1.4, a per-list config parameter for "max_days_to_hold" was added, and bin/checkdbs uses it to expire held messages. But it supports only discard, and not reject/comment or approve. Also, it does not deal with stale held messages whose lists have since been deleted.
See patch #1394949.
--Robby