
May 7, 2002
12:12 a.m.
"HK" == Harald Koch <chk@pobox.com> writes:
HK> However, my 'trick' of adding a Sender: field doesn't work
HK> anymore, and I get a confusing log/hold message that says
HK> "humour post from chk@cfrq.net held: Post by a moderated
HK> member". 'chk@cfrq.net' is not moderated.
HK> It turns out that, in order to find the moderation flag of the
HK> user that send a message, Handlers/Moderate.py calls
HK> msg.get_senders, which returns a *list* of senders with the
HK> Sender: last; Moderate.py only looks at the first return
HK> value, which is the From: header. The address in the From:
HK> field *is* moderated, and so the message is rejected. Later,
HK> however, Handlers/Hold.py routine hold_for_approval calls the
HK> old msg.get_sender (singular vs. plural), which returns the
HK> Sender: field if "USE_ENVELOPE_SENDER = 1" is set, which is
HK> why I get the confusing log message.
HK> So, two things:
HK> 1) The message rejection is confusing.
HK> 2) What's the right way to do this under 2.1?
Later...
"HK" == Harald Koch <chk@pobox.com> writes:
HK> Ok, I just found the Approved: header processing... *sigh.
HK> The hold message is still confusing though. <grin>
You're right it is. And I'll fix that.
I believe that using the Approved: header is the better way to go, since it's more difficult to fake out (someone would have to have the list admin password, rather than trivially be able to forge the Sender: or From: or whatever header).
-Barry