Prospective GSoC student - Need Help Understanding Pipeline Failure on First PR
Hello,
I am Pronay Sarker. I managed to solve a “good first issue” and submitted a PR. However, the pipelines are failing, and I’m unable to figure out why.
On GitHub, when we click on the pipelines, it usually shows the log trace explaining exactly why it failed. But here, that doesn’t seem to be the case. When I clicked on the pipeline and went to the job section, it was empty. So I’m unable to determine the reason for the failure.
Without knowing why it’s failing, I won’t be able to fix it. Could someone please help me understand why it’s failing!
Here is a link to my pull request. I have added a screenshot there as well. - https://gitlab.com/mailman/mailman/-/merge_requests/1432
On 2/21/26 09:51, 2023100000376--- via Mailman-Developers wrote:
I am Pronay Sarker. I managed to solve a “good first issue” and submitted a PR. However, the pipelines are failing, and I’m unable to figure out why.
On GitHub, when we click on the pipelines, it usually shows the log trace explaining exactly why it failed. But here, that doesn’t seem to be the case. When I clicked on the pipeline and went to the job section, it was empty. So I’m unable to determine the reason for the failure.
Hover over or click the error button and maybe the yaml invalid button.
Without knowing why it’s failing, I won’t be able to fix it. Could someone please help me understand why it’s failing!
See my comments on your MR.
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
Hello,
I am having hard time locating where the tests for BanManager.is_banned()
are located. I am supposed to create tests for
Banmanager.is_banned_globally() as suggested in my PR
<https://gitlab.com/mailman/mailman/-/merge_requests/1432#note_3103197264>.
so I am looking for BanManager.is_banned() as a reference.
In the codebase, I found two test_ban.py test files, one in model and
one in rest, and I am not sure where to write tests for
Banmanager.is_banned_globally(), as I could not find tests related to
Banmanager.is_banned() in both (rest and model test) the files
Could anyone please help me to locate that!
Thank you gitlab/github- itsPronay
--
251/A and 252, Tejgaon Industrial Area, Dhaka - 1208, Bangladesh. Mob: 019117-81327, 01766-348518 Web: www.seu.edu.bd <https://www.seu.edu.bd>, Email: info@seu.edu.bd <mailto:info@seu.edu.bd>
Pronay Sarker via Mailman-Developers writes:
I am having hard time locating where the tests for BanManager.is_banned() are located.
Mailman makes heavy use of "doctests". https://docs.python.org/3/library/doctest.html Look in app/docs/bans.rst.
Steve
-- GNU Mailman consultant (installation, migration, customization) Sirius Open Source https://www.siriusopensource.com/ Software systems consulting in Europe, North America, and Japa
participants (4)
-
2023100000376＠seu.edu.bd -
Mark Sapiro -
Pronay Sarker
-
Stephen J. Turnbull