
(Mailman 2.1.8)
Probably trivial; probably my misunderstanding. But...
... at the end of "Approve.py" is some code to detect multiple passes through a list ("x-beenthere" etc.).
But "Approve.py" is about handling passwords, whereas loop-detection has no relation to such authentication issues. Shouldn't this loop detection functionality be in some other place, not "Approve.py"? For instance, perhaps in its own, almost trivial, handler?
(I noticed it because I'm writing an experimental sender-authentication scheme as a custom handler modelled on "Approve.py".)
BTW: Overall, as I dig into the Mailman code, I'm increasingly impressed with its usually clean modularisation and its flexibility. So this loop-detection (mis-)placement seems out of character.
Many thanks for a good product.

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Jul 5, 2006, at 10:26 AM, David Lee wrote:
(Mailman 2.1.8)
Probably trivial; probably my misunderstanding. But...
... at the end of "Approve.py" is some code to detect multiple passes through a list ("x-beenthere" etc.).
But "Approve.py" is about handling passwords, whereas loop- detection has no relation to such authentication issues. Shouldn't this loop
detection functionality be in some other place, not "Approve.py"? For instance, perhaps in its own, almost trivial, handler?
Ideally, yes, that's probably how it should (eventually?) be
implemented. It's the way it is mostly due to historical accident.
(I noticed it because I'm writing an experimental sender- authentication scheme as a custom handler modelled on "Approve.py".)
BTW: Overall, as I dig into the Mailman code, I'm increasingly
impressed with its usually clean modularisation and its flexibility. So this loop-detection (mis-)placement seems out of character.Many thanks for a good product.
Thanks!
- -Barry
participants (2)
-
Barry Warsaw
-
David Lee