my patches are availabe via www
Hiyas,
My patches can be downloaded from http://www.kva.hu/~mailman. Please check'em out.
I've fixed some bugs in'em.
Bug reports are welcomed.
Linux Supporting Center -- Red Hat Qmail packages -- http://lsc.kva.hu PGP 0x1DE3631D / A8 B4 92 EE 1F 55 27 C8 86 64 9C 42 41 A4 BD B8
I've integrated 3 of the 4 required patches with the mailman distribution, but i've gotten a little stumped with the cmdhandler patch.
in MailList.__init__, I had to put InitTempVars before MailCmdHandler.__init__(self) (the patch for MailList.py failed for some reason, it may have been changes to the source i was applying it to though).
in the MailCommandHandler module, I had to add a "cmdmode = 0" near the top of ParseMailCommand because it wasn't defined and was throwing a NameError if you sent it a plain "help" command. same sort of thing happened with the definition of the "txt" variable when sending a plain "help" command.
in addition, I had to substitute .GetAbsoluteScriptURL(mm_cfg.{CGI_LISTINFO,CGI_ADMIN}) with GetAbsoluteScriptURL("listinfo") or GetAbsoluteScriptURL("admin").
where did you add mm_cfg.CGI_LISTINFO and why?
do you think we could come up with anything to prettify the output of the "edit all" command -- and perhaps add comments to each variable it spits out? could we maybe replace the "setattr <attr> <value>" command syntax with:
# # <attr> <help text that appears in the cgi # <attr> = <value>
scott
On Fri, Oct 09, 1998 at 12:37:57PM +0200, Balazs Nagy wrote: | Hiyas, | | My patches can be downloaded from http://www.kva.hu/~mailman. Please | check'em out. | | I've fixed some bugs in'em. | | Bug reports are welcomed. | -- | Linux Supporting Center -- Red Hat Qmail packages -- http://lsc.kva.hu | PGP 0x1DE3631D / A8 B4 92 EE 1F 55 27 C8 86 64 9C 42 41 A4 BD B8 | | | | _______________________________________________ | Mailman-Developers maillist - Mailman-Developers@python.org | http://www.python.org/mailman/listinfo/mailman-developers |
On Fri, 9 Oct 1998, Scott wrote:
I've integrated 3 of the 4 required patches with the mailman distribution, but i've gotten a little stumped with the cmdhandler patch.
in MailList.__init__, I had to put InitTempVars before MailCmdHandler.__init__(self) (the patch for MailList.py failed for some reason, it may have been changes to the source i was applying it to though).
In my patch from www: --- mailman.orig/Mailman/MailList.py Tue Sep 29 11:52:38 1998 +++ mailman/Mailman/MailList.py Tue Sep 29 11:52:49 1998 @@ -53,8 +53,8 @@ def __init__(self, name=None, lock=1): if name and name not in Utils.list_names(): raise Errors.MMUnknownListError, 'list not found: %s' % name - MailCommandHandler.__init__(self) self.InitTempVars(name, lock) + MailCommandHandler.__init__(self) if name: self._full_path = os.path.join(mm_cfg.LIST_DATA_DIR, name) self.Load()
in the MailCommandHandler module, I had to add a "cmdmode = 0" near the top of ParseMailCommand because it wasn't defined and was throwing a NameError if you sent it a plain "help" command. same sort of thing happened with the definition of the "txt" variable when sending a plain "help" command.
What patch did you use? Iam very curious because some of my patches' place contains old items.
in addition, I had to substitute .GetAbsoluteScriptURL(mm_cfg.{CGI_LISTINFO,CGI_ADMIN}) with GetAbsoluteScriptURL("listinfo") or GetAbsoluteScriptURL("admin").
Well, I didn't know if I had to write another add-on (see cgiext patch) or no.
where did you add mm_cfg.CGI_LISTINFO and why?
Check my cgi extension patch. I have replaced all direct CGI script names to variables.
do you think we could come up with anything to prettify the output of the "edit all" command -- and perhaps add comments to each variable it spits out? could we maybe replace the "setattr <attr> <value>" command syntax with:
# # <attr> <help text that appears in the cgi # <attr> = <value>
Great! I like it much more now! -- Linux Supporting Center -- Red Hat Qmail packages -- http://lsc.kva.hu PGP 0x1DE3631D / A8 B4 92 EE 1F 55 27 C8 86 64 9C 42 41 A4 BD B8
participants (2)
-
Balazs Nagy -
Scott