Patch patch patch patch patch.... :>
This fixes a nasty (mis)feature of listinfo that if the hostname
you use for your lists' email addresses != the hostname for your base mailman url, the list won't show up on the listinfo page , even if advertized. :P
(for example, all of my lists have host_name= 'lists.integral.org' and web_page_url = 'www.integral.org', so I got nothing on my listinfo page :/ )
-The Dragon De Monsyne
*** /usr/src/mailman-1.0b5/Mailman/Cgi/listinfo.py Mon Jul 27 17:48:31 1998 --- listinfo.py Sat Aug 29 03:25:48 1998
*** 57,62 **** --- 57,63 ----
def FormatListinfoOverview(error=None): "Present a general welcome and itemize the (public) lists for this host."
import urlparse doc = Document() legend = "%s mailing lists" % mm_cfg.DEFAULT_HOST_NAME doc.SetTitle(legend)
*** 74,88 **** # visited! An absolute URL would do... if os.environ.has_key('HTTP_HOST'): http_host = os.environ['HTTP_HOST'] else: ! http_host = None ! for n in names: l = MailList.MailList(n, lock = 0) if l.advertised: if (http_host ! and (string.find(http_host, l.host_name) == -1 ! and string.find(l.host_name, http_host) == -1)): # List is for different identity for this host - skip it. continue else: --- 75,93 ---- # visited! An absolute URL would do... if os.environ.has_key('HTTP_HOST'): http_host = os.environ['HTTP_HOST']
! http_host = None for n in names: l = MailList.MailList(n, lock = 0) if l.advertised:http_host = string.split(string.lower(http_host),':')[0] else:
if http_host:
list_host = string.split(string.lower(urlparse.urlparse(
l.web_page_url)[1]),':')[0]
! and (string.find(http_host, list_host) == -1 ! and string.find(list_host,http_host) == -1)): # List is for different identity for this host - skip it. continue else:if (http_host
In Sat, 29 Aug 1998, The Dragon De Monsyne wrote:
Patch patch patch patch patch.... :>
This fixes a nasty (mis)feature of listinfo that if the hostname you use for your lists' email addresses != the hostname for your base mailman url, the list won't show up on the listinfo page , even if advertized. :P
(for example, all of my lists have host_name= 'lists.integral.org' and web_page_url = 'www.integral.org', so I got nothing on my listinfo page :/ )
This actually is a deliberate feature, for what i consider a good reason
- though perhaps the behavior ought to be selectable.
Imagine you're an ISP who sells "virtual domains", each of which your customers situate their own sets of mailing lists. So each virtual domain has its own (virtual) set of lists. This scenario is by no means far fetched. In fact, here at CNRI we have one machine hosting the lists for a variety of projects, each with their own virtual domain. The people in the projects specifically wanted this partitioning of the lists - as far as their subscribers know, the lists in different virtual domains are in entirely different organizations, on entirely different hosts! I would imagine it'd be even more crucial in the ISP virtual domain scenario.
I suppose it may make sense to offer a site setting by which the site administrator can select whether or not the different domains hosted by a machine are compartmented this way, but i would think the compartmenting mode would be the default one.
(By the way, thanks for your efforts! Among other things, i'm particularly happy to see the standard sendmail.py integration. It'll be nice to not have to maintain our own version!)
ken manheimer klm@python.org
On Sat, 29 Aug 1998, Ken Manheimer wrote:
In Sat, 29 Aug 1998, The Dragon De Monsyne wrote:
Patch patch patch patch patch.... :>
This fixes a nasty (mis)feature of listinfo that if the hostname you use for your lists' email addresses != the hostname for your base mailman url, the list won't show up on the listinfo page , even if advertized. :P
(for example, all of my lists have host_name= 'lists.integral.org' and web_page_url = 'www.integral.org', so I got nothing on my listinfo page :/ )
This actually is a deliberate feature, for what i consider a good reason
- though perhaps the behavior ought to be selectable.
Imagine you're an ISP who sells "virtual domains", each of which your customers situate their own sets of mailing lists. So each virtual domain has its own (virtual) set of lists. This scenario is by no means far fetched. In fact, here at CNRI we have one machine hosting the lists for a variety of projects, each with their own virtual domain. The people in the projects specifically wanted this partitioning of the lists - as far as their subscribers know, the lists in different virtual domains are in entirely different organizations, on entirely different hosts! I would imagine it'd be even more crucial in the ISP virtual domain scenario.
Oh, yes, I know that this is deleberate for virtual hosting.
Virtual hosting will still work with this patch. The only thing this changes is _where_ mailman gets the name of the list's virtual hosname. Before it got it from the list's 'host_name' attribute, which is the hostname put on outgoing email. With this patch it gets the hostname fronm the hostname in the 'web_page_url'. This makes more sense, since it's web virtual hosts you are talking about here.
-The Dragon De Monsyne
participants (2)
-
Ken Manheimer
-
The Dragon De Monsyne