confirmation duplicates and stuff

there's a quick and easy fix to the confirmation duplicates bug.
in the file MailCommandHandler.py, at the end of the definition of the ProcessConfirmCommand method, add "self.__NoMailCmdResponse = 1". This will cause the confirmation handler to either send out only the welcome to the list message, or only the error message if there is one.
I also noticed that listed under Bugs at www.list.org was the fact that confirmations where always called, even when the subscribing address has to be approved administratively. I'd like to point out that the confirmatin step does not take place when a memeber is subscribed via the admin/membership management cgi. However, I believe it does when someone subscribes to a closed list via mail.
I thought that we had all pretty much stated that we always wanted confirmations to happen, but i guess not, seeing how this is listed as a bug. i can see how it could be inconvenient.
The question is: what do we do about this?
do we:
- drop the confirmation step completely when a list has closed subscriptions?
or
- make the confirmation step an option only for closed subscriptions?
#1 is FAR simpler to implement because it doesn't involve any changes to the cgi admin interface. #2 would require a good bit of changes to the interface: either only presenting the confirmation as an option when the list is closed, or allowing it as an option and presenting an error if anyone chooses not have confirmations for an open list.
thoughts?
scott
participants (1)
-
root