Folks:
How does one go about contributing code?
I've made some small changes in my cvs sandbox that I think would be useful for the core code. Do I mail them to someone (Barry?) for consideration, post them here, what?
The mods I made are fairly simple ... when the admlogin, options, and private templates are loaded, the cursor is automaticly placed in the first form field on the page.
I made similar changes in 2.0.11 and my list owners love it.
Thanks!
david
On Sun, Jun 02, 2002 at 05:06:17PM -0500, David Gibbs wrote:
Folks:
How does one go about contributing code?
I've made some small changes in my cvs sandbox that I think would be useful for the core code. Do I mail them to someone (Barry?) for consideration, post them here, what?
If the diff isn't too big, post it here. If it's big or you are afraid the MUA/MTA is going to damanged it, put it on a web site and post a URL.
Marc
Microsoft is to operating systems & security .... .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | Finger marc_f@merlins.org for PGP key
"MM" == Marc MERLIN <marc_news@vasoftware.com> writes:
MM> If the diff isn't too big, post it here. If it's big or you
MM> are afraid the MUA/MTA is going to damanged it, put it on a
MM> web site and post a URL.Better yet, post it on the SF patch manager, so it doesn't get lost in my inbox! ;)
-Barry
At 06:29 PM 6/2/2002, Barry A. Warsaw wrote:
Better yet, post it on the SF patch manager, so it doesn't get lost in my inbox! ;)
Ok. What's the prescribed method of preparing a good diff?
cvs diff?
david
-- | Internet: david@midrange.com | WWW: http://david.fallingrock.net | AIM: MidrangeMan | | If you can't fly, run; if you can't run, walk; | if you can't walk, crawl. | -mlk
On Sun, Jun 02, 2002 at 06:47:34PM -0500, David Gibbs wrote:
At 06:29 PM 6/2/2002, Barry A. Warsaw wrote:
Better yet, post it on the SF patch manager, so it doesn't get lost in my inbox! ;)
Ok. What's the prescribed method of preparing a good diff?
cvs diff?
cvs diff -u :-)
Marc
Microsoft is to operating systems & security .... .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | Finger marc_f@merlins.org for PGP key
On Sun, Jun 02, 2002 at 04:52:57PM -0700, Marc MERLIN wrote:
On Sun, Jun 02, 2002 at 06:47:34PM -0500, David Gibbs wrote:
At 06:29 PM 6/2/2002, Barry A. Warsaw wrote:
Better yet, post it on the SF patch manager, so it doesn't get lost in my inbox! ;)
Ok. What's the prescribed method of preparing a good diff?
cvs diff?
cvs diff -u :-)
Mmmh, no, that'd make your patch inversed.
Make two dirs: mailman-cvs mailman-yourtree and do a diff -urN mailman-cvs mailman-yourtree > yourpatches.diff
Marc
Microsoft is to operating systems & security .... .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | Finger marc_f@merlins.org for PGP key
At 06:54 PM 6/2/2002, Marc MERLIN wrote:
cvs diff -u :-) Mmmh, no, that'd make your patch inversed.
You sure? I just ran a diff on my patch and it looks right to me...
Line I replace has a "-" in front of it, line I replaced it with as a "+" in front.
Make two dirs: mailman-cvs mailman-yourtree and do a diff -urN mailman-cvs mailman-yourtree > yourpatches.diff
Ech, that's a lot of work when we have a change management system.
david
Marc
Microsoft is to operating systems & security .... .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | Finger marc_f@merlins.org for PGP key
-- | Internet: david@midrange.com | WWW: http://david.fallingrock.net | AIM: MidrangeMan | | If you can't fly, run; if you can't run, walk; | if you can't walk, crawl. | -mlk
On Sun, Jun 02, 2002 at 06:58:44PM -0500, David Gibbs wrote:
At 06:54 PM 6/2/2002, Marc MERLIN wrote:
cvs diff -u :-) Mmmh, no, that'd make your patch inversed.
You sure? I just ran a diff on my patch and it looks right to me...
Never mind, you're right. Too much hacking, not enough sleep.
Please ignore me.
Marc
Microsoft is to operating systems & security .... .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | Finger marc_f@merlins.org for PGP key
"DG" == David Gibbs <david@midrange.com> writes:
DG> Ok, I posted it on sf. It's patch #563686.Thanks. Yup, "cvs diff -u" is the preferred mechanism. You'll need to do -N if you're adding new files (but you can also just post the new files themselves). I can grok context diffs (-C 2) but unifieds are much preferred.
Thanks, -Barry
participants (3)
-
barry＠zope.com -
David Gibbs -
Marc MERLIN