bug in tests/test_handlers.py
with http://bazaar.launchpad.net/~mailman-coders/mailman/2.1/revision/1376 “ Setting digest_size_threshhold to zero now means no digests will be sent based on size instead of a digest being sent with every post. “ tests/test_handlers.py sets digest_size_threshhold to 0. I assume this is an attempt to force the digest send. But now 0 means ‘no digest’. Below is my proposed patch to trick ToDigest into sending. steve --- /usr/local/mailman/tests/test_handlers.py.old 2013-12-19 11:57:09.745503688 -0800 +++ /usr/local/mailman/tests/test_handlers.py 2013-12-19 11:26:18.325853268 -0800 @@ -1880,7 +1880,7 @@ Here is message %(i)d msg = self._makemsg(99) print msg size = os.path.getsize(self._path) + len(str(msg)) - mlist.digest_size_threshhold = 0 + mlist.digest_size_threshhold = .001 ToDigest.process(mlist, msg, {}) files = self._sb.files() # There should be two files in the queue, one for the MIME digest and
On 12/19/2013 12:07 PM, Stephen Willey Mats Mats wrote:
tests/test_handlers.py sets digest_size_threshhold to 0. I assume this is an attempt to force the digest send. But now 0 means ‘no digest’. Below is my proposed patch to trick ToDigest into sending.
Thanks for the report and patch. This and two other failures have been fixed. See <https://bugs.launchpad.net/mailman/+bug/1262950> and <http://bazaar.launchpad.net/~mailman-coders/mailman/2.1/revision/1441>.
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
participants (2)
-
Mark Sapiro
-
Stephen Willey Mats Mats