Re: [Mailman-Developers] [Mailman-checkins] SF.net SVN: mailman: [8181] trunk/mailman/Mailman
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Tokio, Thanks for the patches, and especially the test cases! I have a couple of questions for you. I noticed that current trunk is failing three tests: test_no_multipart_mixed_charset test_scrub_image test_scrub_text Can you check to see if those are failing for you? Also I was wondering about the latest change to passwords.py: On Mar 24, 2007, at 10:57 PM, tkikuchi@users.sourceforge.net wrote:
Modified: trunk/mailman/Mailman/passwords.py =================================================================== --- trunk/mailman/Mailman/passwords.py 2007-03-24 06:01:35 UTC (rev 8180) +++ trunk/mailman/Mailman/passwords.py 2007-03-25 02:57:18 UTC (rev 8181) @@ -240,6 +240,9 @@ scheme = scheme_parts[0].lower() scheme_enum = _SCHEMES_BY_TAG.get(scheme, _DEFAULT_SCHEME) scheme_class = _SCHEMES_BY_ENUM[scheme_enum] + if isinstance(rest_group, unicode): + # decode() fails. (challenge is from database) + rest_group = str(rest_group) return scheme_class.check_response(rest_group, response, *scheme_parts[1:])
Earlier, I was using s.encode('utf-8') to ensure that we had an 8-bit string for the hash function. I'm wondering if you prefer str() over .encode('utf-8') here and if so, what the reason is? Cheers, - -Barry -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iQCVAwUBRghtRXEjvBPtnXfVAQJAXQP/enWB9iOvVDJ6B+k3ggN32EjszSH4XvKU lY9A6gomMIdE+gIivNtbBx6ziv6w2AvYkV2fBC3sc5ooyZGQesjl5gpeZ53AwCyF HF9bVQuW72L9TxvWIYOO+wnADr97YyYSU/rNHT7GPua5Z+1SnwF5FQknFtpVFZdO yqzwK5b5C5E= =moCg -----END PGP SIGNATURE-----
Hi Barry,
I noticed that current trunk is failing three tests:
test_no_multipart_mixed_charset test_scrub_image test_scrub_text
Can you check to see if those are failing for you?
I've confirmed sucess (colinux/debian python2.4) but check them more, on different environments.
Also I was wondering about the latest change to passwords.py:
Earlier, I was using s.encode('utf-8') to ensure that we had an 8-bit
string for the hash function. I'm wondering if you prefer str()
over .encode('utf-8') here and if so, what the reason is?
I was just re-entering the last patch but there may remain older data in my installation. I'll check it in a fresh install and make correction. If 'rest_group' is a hashed password, it should be in the ascii range but we are going to allow plain password which I fogot.
-- Tokio Kikuchi, tkikuchi@is.kochi-u.ac.jp http://weather.is.kochi-u.ac.jp/
Hi,
I noticed that current trunk is failing three tests:
test_no_multipart_mixed_charset test_scrub_image test_scrub_text
I was using the latest svn of email. :-)
BTW, I can't create a new list in my fresh installation.
# bin/newlist test Traceback (most recent call last): File "bin/newlist", line 48, in <module> main() File "bin/newlist", line 39, in main status = sys.modules[module_name].main() File "/usr/local/mailman/Mailman/bin/newlist.py", line 101, in main parser, opts, args = parseargs() File "/usr/local/mailman/Mailman/bin/newlist.py", line 92, in parseargs if opts.password_scheme.lower() not in passwords.SCHEMES: AttributeError: 'module' object has no attribute 'SCHEMES'
-- Tokio Kikuchi, tkikuchi@is.kochi-u.ac.jp http://weather.is.kochi-u.ac.jp/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Mar 26, 2007, at 10:25 PM, Tokio Kikuchi wrote:
Hi,
I noticed that current trunk is failing three tests: test_no_multipart_mixed_charset test_scrub_image test_scrub_text
I was using the latest svn of email. :-)
Hmm, I /think/ I'm using the email 4.0.1 from misc. One of the
things I'm trying to do next (other than resolve and commit all the
changes I made while at Pycon) is to convert things to use setuptools
so I don't have to keep installing everything just to test them!
BTW, I can't create a new list in my fresh installation.
# bin/newlist test Traceback (most recent call last): File "bin/newlist", line 48, in <module> main() File "bin/newlist", line 39, in main status = sys.modules[module_name].main() File "/usr/local/mailman/Mailman/bin/newlist.py", line 101, in main parser, opts, args = parseargs() File "/usr/local/mailman/Mailman/bin/newlist.py", line 92, in
parseargs if opts.password_scheme.lower() not in passwords.SCHEMES: AttributeError: 'module' object has no attribute 'SCHEMES'
Confirmed. I'll fix this.
- -Barry
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin)
iQCVAwUBRgiEwnEjvBPtnXfVAQLT6AQAhB+XXg7VIxmn4Yl7KmTHy/8fTrQoe+mG eawINEzzwj/JbJm/6al9paEv8UvDaJk6L1+yCbzGleE5spdR4E0cYEkxPEQ5RW+6 lkTFcVs/+9ulIcQ2Plew710hEg6qd2851ip0EJ0paGcaAK9aRE0V6029ze2N6xmf lcjWCmseitE= =C59g -----END PGP SIGNATURE-----
participants (2)
-
Barry Warsaw -
Tokio Kikuchi