![](https://secure.gravatar.com/avatar/08fb585b8f06c4c6529a8866a1921d86.jpg?s=120&d=mm&r=g)
It looks like the "massive rewrite" that occured between revisions 2.5 and 2.5 of cron/mailpasswds removed the SuppressPasswordReminder check.
Attached is a totally untested patch provided simply to suggest a possible fix.
-- Jon Parise (jon@csh.rit.edu) :: http://www.csh.rit.edu/~jon/
![](https://secure.gravatar.com/avatar/08fb585b8f06c4c6529a8866a1921d86.jpg?s=120&d=mm&r=g)
On Sun, Feb 02, 2003 at 09:14:22PM -0500, Jon Parise wrote:
It looks like the "massive rewrite" that occured between revisions 2.5 and 2.5 of cron/mailpasswds removed the SuppressPasswordReminder check.
Attached is a totally untested patch provided simply to suggest a possible fix.
Just a note that I was able to verify that the following patch does indeed fix the problem. I'll submit a SourceForge patch so this doesn't get lost.
Index: mailpasswds =================================================================== RCS file: /cvsroot/mailman/mailman/cron/mailpasswds,v retrieving revision 2.14 diff -u -r2.14 mailpasswds --- mailpasswds 2 Jan 2003 05:40:57 -0000 2.14 +++ mailpasswds 3 Feb 2003 02:12:47 -0000 @@ -136,6 +136,10 @@ for mlist in byhost[host]: listaddr = mlist.GetListEmail() for member in mlist.getMembers(): + # The user may have disabled password reminders for this list + if mlist.getMemberOption(member, + mm_cfg.SuppressPasswordReminder): + continue # Group by the lower-cased address, since Mailman always # treates person@dom.ain the same as PERSON@dom.ain. password = mlist.getMemberPassword(member)
-- Jon Parise (jon@csh.rit.edu) :: http://www.csh.rit.edu/~jon/
![](https://secure.gravatar.com/avatar/01aa7d6d4db83982a2f6dd363d0ee0f3.jpg?s=120&d=mm&r=g)
"JP" == Jon Parise <jon@csh.rit.edu> writes:
JP> It looks like the "massive rewrite" that occured between
JP> revisions 2.5 and 2.5 of cron/mailpasswds removed the
JP> SuppressPasswordReminder check.
JP> Attached is a totally untested patch provided simply to
JP> suggest a possible fix.
Seems good to me, and I've applied it to cvs. Thanks! -Barry
participants (2)
-
barry@python.org
-
Jon Parise