nightly_gzip not compressing weeklys?

Does nightly_gzip only handle monthlies? It's not clear from the code (and my knowledge of python :-)), but it sure looks like it's only compressing monthlys.

"RJ" == Ron Jarrell <jarrell@vt.edu> writes:
RJ> Does nightly_gzip only handle monthlies? It's not clear from
RJ> the code (and my knowledge of python :-)), but it sure looks
RJ> like it's only compressing monthlys.
Back in February, Thomas Wouters suggested this patch. It seems to work for me so I'll go ahead and commit it.
-Barry
Index: nightly_gzip
RCS file: /projects/cvsroot/mailman/cron/nightly_gzip,v retrieving revision 1.5 diff -c -r1.5 nightly_gzip *** nightly_gzip 2000/03/21 06:26:25 1.5 --- nightly_gzip 2000/04/27 20:26:28
*** 111,121 **** if mlist.last_post_time > 0: print 'List', name, 'has a bogus archive_directory:', dir continue files = [] for f in allfiles: ! try: ! time.strptime(f, '%Y-%B.txt') ! except ValueError: continue # stat both the .txt and .txt.gz files and append them only if # the former is newer than the latter. --- 111,121 ---- if mlist.last_post_time > 0: print 'List', name, 'has a bogus archive_directory:', dir continue
if VERBOSE:
! if f[-4:] <> '.txt': continue # stat both the .txt and .txt.gz files and append them only if # the former is newer than the latter.print 'Processing list:', name files = [] for f in allfiles:

On Thu, Apr 27, 2000 at 04:34:37PM -0400, Barry A. Warsaw wrote:
Back in February, Thomas Wouters suggested this patch. It seems to work for me so I'll go ahead and commit it.
It wasn't me. Or at least I dont think it was. The VERBOSE bit is certainly not mine, and I seem to recall someone else suggesting this patch. I probably commented on it, though, because the use of time.strptime bugged me -- BSDI doesn't have strptime. As I can't find this patch in any of my Mailman installs, patch archives and mailboxes, I'm fairly sure it's not me who's seeing premature signs of old age ;)
Will the the real contributor please rise ? ;)
Index: nightly_gzip
-- Thomas Wouters <thomas@xs4all.net>
Hi! I'm a .signature virus! copy me into your .signature file to help me spread!

"TW" == Thomas Wouters <thomas@xs4all.net> writes:
TW> It wasn't me. Or at least I dont think it was. The VERBOSE bit
TW> is certainly not mine, and I seem to recall someone else
TW> suggesting this patch. I probably commented on it, though,
TW> because the use of time.strptime bugged me -- BSDI doesn't
TW> have strptime. As I can't find this patch in any of my Mailman
TW> installs, patch archives and mailboxes, I'm fairly sure it's
TW> not me who's seeing premature signs of old age ;)
Hey, I resemble that remark! Naw, I added the VERBOSE bit and it leaked into my posted patch.
-Barry

"RJ" == Ron Jarrell <jarrell@vt.edu> writes:
RJ> Does nightly_gzip only handle monthlies? It's not clear from
RJ> the code (and my knowledge of python :-)), but it sure looks
RJ> like it's only compressing monthlys.
Back in February, Thomas Wouters suggested this patch. It seems to work for me so I'll go ahead and commit it.
-Barry
Index: nightly_gzip
RCS file: /projects/cvsroot/mailman/cron/nightly_gzip,v retrieving revision 1.5 diff -c -r1.5 nightly_gzip *** nightly_gzip 2000/03/21 06:26:25 1.5 --- nightly_gzip 2000/04/27 20:26:28
*** 111,121 **** if mlist.last_post_time > 0: print 'List', name, 'has a bogus archive_directory:', dir continue files = [] for f in allfiles: ! try: ! time.strptime(f, '%Y-%B.txt') ! except ValueError: continue # stat both the .txt and .txt.gz files and append them only if # the former is newer than the latter. --- 111,121 ---- if mlist.last_post_time > 0: print 'List', name, 'has a bogus archive_directory:', dir continue
if VERBOSE:
! if f[-4:] <> '.txt': continue # stat both the .txt and .txt.gz files and append them only if # the former is newer than the latter.print 'Processing list:', name files = [] for f in allfiles:

On Thu, Apr 27, 2000 at 04:34:37PM -0400, Barry A. Warsaw wrote:
Back in February, Thomas Wouters suggested this patch. It seems to work for me so I'll go ahead and commit it.
It wasn't me. Or at least I dont think it was. The VERBOSE bit is certainly not mine, and I seem to recall someone else suggesting this patch. I probably commented on it, though, because the use of time.strptime bugged me -- BSDI doesn't have strptime. As I can't find this patch in any of my Mailman installs, patch archives and mailboxes, I'm fairly sure it's not me who's seeing premature signs of old age ;)
Will the the real contributor please rise ? ;)
Index: nightly_gzip
-- Thomas Wouters <thomas@xs4all.net>
Hi! I'm a .signature virus! copy me into your .signature file to help me spread!

"TW" == Thomas Wouters <thomas@xs4all.net> writes:
TW> It wasn't me. Or at least I dont think it was. The VERBOSE bit
TW> is certainly not mine, and I seem to recall someone else
TW> suggesting this patch. I probably commented on it, though,
TW> because the use of time.strptime bugged me -- BSDI doesn't
TW> have strptime. As I can't find this patch in any of my Mailman
TW> installs, patch archives and mailboxes, I'm fairly sure it's
TW> not me who's seeing premature signs of old age ;)
Hey, I resemble that remark! Naw, I added the VERBOSE bit and it leaked into my posted patch.
-Barry
participants (3)
-
Barry A. Warsaw
-
Ron Jarrell
-
Thomas Wouters