Re: [Mailman-Developers] (no subject)
On Jan 16, 2013, at 04:06 AM, Sandesh Agrawal wrote:
I looked into ConfigurationUpdatedEvent and mailman.cfg and got the bug corrected :)
Now coming to creation of test , i am unsure about how to create a test for the bug and what all things to include in it. I would really like to know more about it so that i can create the required test and send a merge proposal.
I think the tests can be fairly simple, since all you care about is that the queue directories don't get created. As long as the rest of the test suite runs without failures, that should be enough. (I'm still working on getting coverage into the test suite.)
I would suggest adding a test to mailman/runners/tests/test_lmtp.py that asserts there's no lmtp queue directory.
For the RESTRunner, there's no equivalent mailman/runners/tests/test_rest.py. You *could* add one, but I'm not sure it's worth it for this one check. Maybe you could add such a test to mailman/rest/tests/test_root.py?
Cheers, -Barry
I tried running ./bin/test and saw the following erro coming up :
Failure in test /home/sandesh/mail_man/mailman-3.0.0b2/src/mailman/commands/docs/inject.rst Failed doctest test for inject.rst File "/home/sandesh/mail_man/mailman-3.0.0b2/src/mailman/commands/docs/inject.rst", line 0
File "/home/sandesh/mail_man/mailman-3.0.0b2/src/mailman/commands/docs/inject.rst", line 29, in inject.rst Failed example: command.process(args) Differences (ndiff with -expected +actual): Available queues: archive bad bounces command digest in - lmtp nntp out pipeline - rest retry shunt virgin
The reason for this was , in mailman/commands/cli_inject.py , when arg.show = True , it tries to fetch the available queues using : if args.show: print('Available queues:') for switchboard in sorted(config.switchboards): print(' ', switchboard) return
But since , is_non_queue_runner is set True for lmtp and rest runner, switchboard instance is not created for them , hence config.switchboards does not have an entry for lmtp and rest. Is this another bug in the way of fetching available queues ?
participants (2)
-
Barry Warsaw -
Sandesh Agrawal