Slightly lame logging: web subscription request

It appears that MM 2.1b4's logging of web subscription requests is a bit lame -- it doesn't actually log the email address involved, just the real name. Is this deliberate?
Greg
-- Greg Ward - software developer gward@mems-exchange.org MEMS Exchange http://www.mems-exchange.org

"GW" == Greg Ward <gward@mems-exchange.org> writes:
GW> It appears that MM 2.1b4's logging of web subscription
GW> requests is a bit lame -- it doesn't actually log the email
GW> address involved, just the real name. Is this deliberate?
No. I'll have to double check this when I get a chance. -Barry

On 28 October 2002, Barry A. Warsaw said:
No. I'll have to double check this when I get a chance.
OK. If it helps, here are some log excerpts. First, Apache:
24.202.9.108 - - [28/Oct/2002:11:09:27 -0500] "GET /mailman/listinfo/mems-announce HTTP/1.1" 200 6451 "http://mail.mems-exchange.org/mailman/listinfo/" "Opera/6.1 (Linux 2.4.19-gw i686; U) [en]" "SSL -" 0sec 24.202.9.108 - - [28/Oct/2002:11:12:04 -0500] "POST /mailman/subscribe/mems-announce HTTP/1.1" 200 1202 "http://mail.mems-exchange.org/mailman/listinfo/mems-announce" "Opera/6.1 (Linux 2.4.19-gw i686; U) [en]" "SSL -" 1sec
I entered the subscribe form with email="xxx@gerg.ca" (censored since I don't like revealing addresses in my personal domain) and fullname="Greg Ward". Here's what Mailman logged:
==> subscribe <== Oct 28 11:12:04 2002 (26884) mems-announce: pending Greg Ward 24.202.9.108
==> smtp <== Oct 28 11:12:05 2002 (24845) <mailman.0.1035821524.26884.mems-announce@memsnet.org> smtp for 1 recips, completed in 0.157 seconds
and here's what Exim logged for the outgoing confirmation mail:
2002-10-28 11:12:05 186CUm-0006zf-00 <= mems-announce-bounces@memsnet.org H=localhost (kronos.mems-exchange.org) [127.0.0.1] P=esmtp S=1884 id=mailman.0.1035821524.26884.mems-announce@memsnet.org 2002-10-28 11:12:06 186CUm-0006zf-00 => xxx@gerg.ca R=special_lookuphost T=special_remote_smtp H=cthulhu.gerg.ca [24.202.9.108] 2002-10-28 11:12:06 186CUm-0006zf-00 Completed
Greg

On Mon, Oct 28, 2002 at 11:16:16AM -0500, Barry A. Warsaw wrote:
As this ist still in 2.1b5, I had a look. The following patch fixed it for me, but I don't understand the case I didn't fix (umbrella lists?). Jost --- /usr/local/mailman/Mailman/MailList.py.ORIG Wed Nov 27 12:01:18 2002 +++ /usr/local/mailman/Mailman/MailList.py Wed Nov 27 12:01:44 2002 @@ -821,7 +821,7 @@ if recipient <> email: who = "%s (%s)" % (email, recipient.split('@')[0]) else: - who = name + who = "%s (%s)" % (email, name) syslog('subscribe', '%s: pending %s %s', self.internal_name(), who, by) raise Errors.MMSubscribeNeedsConfirmation -- | Jost.Krieger+sig@ruhr-uni-bochum.de Please help stamp out spam! | | Postmaster, JAPH, resident answer machine am RZ der RUB | | Pluralitas non est ponenda sine necessitate | | William of Ockham (1285-1347/49) |

"GW" == Greg Ward <gward@mems-exchange.org> writes:
GW> It appears that MM 2.1b4's logging of web subscription
GW> requests is a bit lame -- it doesn't actually log the email
GW> address involved, just the real name. Is this deliberate?
No. I'll have to double check this when I get a chance. -Barry

On 28 October 2002, Barry A. Warsaw said:
No. I'll have to double check this when I get a chance.
OK. If it helps, here are some log excerpts. First, Apache:
24.202.9.108 - - [28/Oct/2002:11:09:27 -0500] "GET /mailman/listinfo/mems-announce HTTP/1.1" 200 6451 "http://mail.mems-exchange.org/mailman/listinfo/" "Opera/6.1 (Linux 2.4.19-gw i686; U) [en]" "SSL -" 0sec 24.202.9.108 - - [28/Oct/2002:11:12:04 -0500] "POST /mailman/subscribe/mems-announce HTTP/1.1" 200 1202 "http://mail.mems-exchange.org/mailman/listinfo/mems-announce" "Opera/6.1 (Linux 2.4.19-gw i686; U) [en]" "SSL -" 1sec
I entered the subscribe form with email="xxx@gerg.ca" (censored since I don't like revealing addresses in my personal domain) and fullname="Greg Ward". Here's what Mailman logged:
==> subscribe <== Oct 28 11:12:04 2002 (26884) mems-announce: pending Greg Ward 24.202.9.108
==> smtp <== Oct 28 11:12:05 2002 (24845) <mailman.0.1035821524.26884.mems-announce@memsnet.org> smtp for 1 recips, completed in 0.157 seconds
and here's what Exim logged for the outgoing confirmation mail:
2002-10-28 11:12:05 186CUm-0006zf-00 <= mems-announce-bounces@memsnet.org H=localhost (kronos.mems-exchange.org) [127.0.0.1] P=esmtp S=1884 id=mailman.0.1035821524.26884.mems-announce@memsnet.org 2002-10-28 11:12:06 186CUm-0006zf-00 => xxx@gerg.ca R=special_lookuphost T=special_remote_smtp H=cthulhu.gerg.ca [24.202.9.108] 2002-10-28 11:12:06 186CUm-0006zf-00 Completed
Greg

On Mon, Oct 28, 2002 at 11:16:16AM -0500, Barry A. Warsaw wrote:
As this ist still in 2.1b5, I had a look. The following patch fixed it for me, but I don't understand the case I didn't fix (umbrella lists?). Jost --- /usr/local/mailman/Mailman/MailList.py.ORIG Wed Nov 27 12:01:18 2002 +++ /usr/local/mailman/Mailman/MailList.py Wed Nov 27 12:01:44 2002 @@ -821,7 +821,7 @@ if recipient <> email: who = "%s (%s)" % (email, recipient.split('@')[0]) else: - who = name + who = "%s (%s)" % (email, name) syslog('subscribe', '%s: pending %s %s', self.internal_name(), who, by) raise Errors.MMSubscribeNeedsConfirmation -- | Jost.Krieger+sig@ruhr-uni-bochum.de Please help stamp out spam! | | Postmaster, JAPH, resident answer machine am RZ der RUB | | Pluralitas non est ponenda sine necessitate | | William of Ockham (1285-1347/49) |
participants (3)
-
barry@python.org
-
Greg Ward
-
Jost Krieger