[ mailman-Patches-558208 ] Unescaped HTML in subject lines
Patches item #558208, was opened at 2002-05-20 10:16 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=300103&aid=558208&group_id=103
Category: Pipermail Group: Mailman 2.0.x Status: Open Resolution: None Priority: 5 Submitted By: Tristan Roddis (tristan_roddis) Assigned to: Nobody/Anonymous (nobody) Summary: Unescaped HTML in subject lines
Initial Comment: Currently (in 2.0.x and up to 2.1b2), then the archive index pages do not escape HTML in the subject lines of posts. This exposes the possibility of malicious or annoying list members being able to invoke cross site javascript on the index pages, or simply corrupt the archive display by adding HTML fragments (e.g. '<font size="10"> without a corresponding </font>')
The fix is extremely simple, just edit the file /home/mailman/Mailman/Archiver/HyperArch.py so that the function write_index_entry() (which starts at or near line 882 in v2.06) so that its last line reads as follows:
print index_entry_template % (urllib.quote
(article.filename), html_quote (subject), article.sequence, author)
[i.e. add the crucial html_quote() function around the subject]
Hope that helps,
-Tristan.
You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=300103&aid=558208&group_id=103
participants (1)
-
noreply@sourceforge.net