Re: [Mailman-Developers] [Bug 937154] Re: bin/disabled.py is nonfunctional
On Mar 26, 2012, at 08:03 PM, Andrea Crotti wrote:
Should it provide exactly the same command line interface?
Not necessarily. Looking at the code now I think the long options are probably fine, but I'm not sure the short options are great (e.g. -o is usually reserved for output to a file; not relevant for this particular script, but I don't like appropriating commonly understood options if at all possible). Also --unknown won't be useful now; that was a nod to some bug in MM2.1 we never figured out. ;) If you make it a bin/mailman subcommand, you won't need to re-implement -C here.
- Does it need to be independent from the rest of the code or should it be added to the mailman commands??
I think I would make it a bin/mailman subcommand. One of the main use cases for this script is to implement a cron job that site admins can enable to process users in various statuses. But I think a cron could invoke a subcommand just fine. Still, that use case should inform its cli.
Anything else that I should know?
One thing to keep in mind is that in mm3, I'm trying to reduce the amount of logic in the actual commands. Meaning, it would be better to move as much as possible into core services, and have the command do as little as possible, over cli parsing and such.
participants (1)
-
Barry Warsaw