Patch 1107169: Re-use member_moderation_notice for generic_nonmember_action
Folks,
I asked a couple of questions about this a while back, and got a bit of help that allowed me to develop a patch, which I've now had on SourceForge for a while (see <http://sourceforge.net/tracker/index.php?func=detail&aid=1107169&group_id=103&atid=300103>).
However, I haven't heard any further commentary on this. I'm not a programmer in any language, especially Python, but I hope that I've been able to at least hack something together without causing too much collateral damage. Feedback would be appreciated.
Tokio -- can I get you to take a look at this and consider it for inclusion in your next beta roll-up for 2.1.6? This would solve some problems for us on the mailman-users and mailman-developers mailing lists, and without at least some commentary from you or Barry, I'm hesitant to just go ahead and apply this to the mailing list server for python.org.
Thanks!-- Brad Knowles, <brad@stop.mail-abuse.org>
"Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety."
-- Benjamin Franklin (1706-1790), reply of the Pennsylvania
Assembly to the Governor, November 11, 1755SAGE member since 1995. See <http://www.sage.org/> for more info.
Hi,
Brad Knowles wrote:
Folks,
I asked a couple of questions about this a while back, and got a bitof help that allowed me to develop a patch, which I've now had on SourceForge for a while (see <http://sourceforge.net/tracker/index.php?func=detail&aid=1107169&group_id=103&atid=300103>).
However, I haven't heard any further commentary on this. I'm not aprogrammer in any language, especially Python, but I hope that I've been able to at least hack something together without causing too much collateral damage. Feedback would be appreciated.
I was thinking that it would be better to have another text box to input say 'nonmember_rejection_notice' in the admin/privacy/sender page so the list owner can differentiate members and nonmembers. And I, having troubled by my students' theses, thought it would also better not to integrate your patch now but leave it open for use who need this.
Tokio -- can I get you to take a look at this and consider it forinclusion in your next beta roll-up for 2.1.6? This would solve some problems for us on the mailman-users and mailman-developers mailing lists, and without at least some commentary from you or Barry, I'm hesitant to just go ahead and apply this to the mailing list server for python.org.
But, you need this for python.org mailing list! Python.org should use non-patched version of mailman.... I think I can find a time to add a text box and new attribute now. (May be in a day or two)
-- Tokio Kikuchi, tkikuchi@ is.kochi-u.ac.jp http://weather.is.kochi-u.ac.jp/
At 10:22 PM +0900 2005-02-05, Tokio Kikuchi wrote:
I was thinking that it would be better to have another text box to input say 'nonmember_rejection_notice' in the admin/privacy/sender page so the list owner can differentiate members and nonmembers.
That would be a better way to solve the problem. Either that, or a new template, somewhat akin to postheld.txt, but used for rejections instead.
And I, havingtroubled by my students' theses, thought it would also better not to integrate your patch now but leave it open for use who need this.
Ahh. Sorry, didn't realize the time/resource crunch. My apologies.But, you need this for python.org mailing list! Python.org should use non-patched version of mailman....
Agreed. ;)I think I can find a time toadd a text box and new attribute now. (May be in a day or two)
Much appreciated. Thanks!-- Brad Knowles, <brad@stop.mail-abuse.org>
"Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety."
-- Benjamin Franklin (1706-1790), reply of the Pennsylvania
Assembly to the Governor, November 11, 1755SAGE member since 1995. See <http://www.sage.org/> for more info.
Hi,
Brad Knowles wrote:
At 10:22 PM +0900 2005-02-05, Tokio Kikuchi wrote:
I was thinking that it would be better to have another text box to input say 'nonmember_rejection_notice' in the admin/privacy/sender page so the list owner can differentiate members and nonmembers.
I think I can find a time toadd a text box and new attribute now. (May be in a day or two)
I've just commited in the developers cvs. It should appear in the public cvs within 24 hours. Please run 'bin/update -f' if you want to test it before the next beta release because usual install will not check the data file version.
(You think me fast? I've almost done this when I mailed last night ;-)
Need-a-sleep-and-a-cup-of-morning-coffee-before-commiting-ly,
Tokio
At 10:43 AM +0900 2005-02-06, Tokio Kikuchi wrote:
I've just commited in the developers cvs. It should appear in the public cvs within 24 hours.
Cool! Thanks!Please run 'bin/update -f' if you want to test itbefore the next beta release because usual install will not check the data file version.
I'm not going to update the version we're running on python.org without first talking to Barry, and seeing if there is some process he wants to go through to do QA testing on it, before we push into production. I don't want to be known as the guy who broke the installation of Mailman on the site where Mailman is developed/supported.
At least not without having at least a couple of other people I can make sure will share the blame with me. ;)
-- Brad Knowles, <brad@stop.mail-abuse.org>
"Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety."
-- Benjamin Franklin (1706-1790), reply of the Pennsylvania
Assembly to the Governor, November 11, 1755SAGE member since 1995. See <http://www.sage.org/> for more info.
participants (2)
-
Brad Knowles -
Tokio Kikuchi