Re: [Mailman-Developers] Possible bug in marilman arch when doing incremental archiving
On 12/13/2013 05:06 AM, fc lists wrote:
When the start is higher then counter, to iterate over the mailbox and get to the starting point requested, the *next()* method on the mbox object is called which trigger the archfactory which extract the attachment from messages that were already archived causing the duplicate attachment to happen.
My "test fix" is basically to set the factory for the mbox object to the default rfc822.Message while iterating over the mbox object until the start is reached , then i set the factory back to the _archfactory ... and everything seems to work as expected.
Thank you for the report. I have created <https://bugs.launchpad.net/mailman/+bug/1260883> for this issue.
I think your fix is OK, but I am inclined to set the factory while skipping to the start to Mailman.Mailbox._safeparser rather than the default just in case one of the skipped messages throws MessageParseError.
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
On 12/13/2013 02:57 PM, Mark Sapiro wrote:
Thank you for the report. I have created <https://bugs.launchpad.net/mailman/+bug/1260883> for this issue.
I think your fix is OK, but I am inclined to set the factory while skipping to the start to Mailman.Mailbox._safeparser rather than the default just in case one of the skipped messages throws MessageParseError.
I have committed a fix. I fixed this in a way that is probably different from what you did because I didn't want to import private Mailman.Mailbox functions into Mailman/Archiver/pipermail.py.
See <http://bazaar.launchpad.net/~mailman-coders/mailman/2.1/revision/1440> for my fix.
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
Thanks a lot for this :)
I will take a look at your fix and most likely import that in my mailman package ... other then anything, i would prefer to have something mantained upstream so i don't have to patch my package every time i upgrade.
On Sat, Dec 14, 2013 at 1:09 AM, Mark Sapiro <mark@msapiro.net> wrote:
On 12/13/2013 02:57 PM, Mark Sapiro wrote:
Thank you for the report. I have created <https://bugs.launchpad.net/mailman/+bug/1260883> for this issue.
I think your fix is OK, but I am inclined to set the factory while skipping to the start to Mailman.Mailbox._safeparser rather than the default just in case one of the skipped messages throws
MessageParseError.
I have committed a fix. I fixed this in a way that is probably different from what you did because I didn't want to import private Mailman.Mailbox functions into Mailman/Archiver/pipermail.py.
See <http://bazaar.launchpad.net/~mailman-coders/mailman/2.1/revision/1440> for my fix.
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
Mailman-Developers mailing list Mailman-Developers@python.org https://mail.python.org/mailman/listinfo/mailman-developers Mailman FAQ: http://wiki.list.org/x/AgA3 Searchable Archives: http://www.mail-archive.com/mailman-developers%40python.org/ Unsubscribe: https://mail.python.org/mailman/options/mailman-developers/fclists%40pr-z.in...
Security Policy: http://wiki.list.org/x/QIA9
participants (2)
-
fc lists -
Mark Sapiro