Upgrade from 1.0b4 -> 1.0b7 fails
I have been running Mailman version 1.0b4 for a while, and decided it was about time to upgrade to the latest version. Everything went well until the point of running the "make update" script then got the following error:
***** If you are installing over an old installation, please ***** run "make update". See the UPGRADING file for details.
katipo 130% make update Traceback (innermost last): File "bin/update", line 10, in ? from Mailman.MailList import MailList File "/home/mailman/Mailman/MailList.py", line 30, in ? import Utils File "/home/mailman/Mailman/Utils.py", line 509, in ? def chunkify(members, chunksize=mm_cfg.DEFAULT_ADMIN_MEMBER_CHUNKSIZE): AttributeError: DEFAULT_ADMIN_MEMBER_CHUNKSIZE
DEFAULT_ADMIN_MEMBER_CHUNKSIZE was not defined in my old mm_cfg.py file, and the mm_cfg.py wasn't installed overtop, but as mm_cfg.py.dist Since the site config is standard I copied across mm_cfg.py.dist into mm_cfg.py and make update completed.
The Python version isn't quite kosher, but I don't think it matters:
Python 1.5.2a2 (#5, Dec 15 1998, 13:16:57) [GCC 2.7.2.1] on freebsd2 Copyright 1991-1995 Stichting Mathematisch Centrum, Amsterdam
Did I install 1.0b4 incorrectly, or does the update script need to be fixed to work around the problem?
BTW - The known problem building under FreeBSD using BSD Make appears to be fixed (have tested on FreeSBD 2.2.5 and 3.0-current). I no longer need GNU Make or hack the Makefile by hand.
Wayne
_____ Wayne Knowles, Systems Manager / o \/ National Institute of Water & Atmospheric Research Ltd \/ v /\ P.O. Box 14-901 Kilbirnie, Wellington, NEW ZEALAND `---' Email: w.knowles@niwa.cri.nz
"WK" == Wayne Knowles <w.knowles@niwa.cri.nz> writes:
WK> Did I install 1.0b4 incorrectly, or does the update script
WK> need to be fixed to work around the problem?
You did everything correctly. It is a problem with the Mailman/Utils.py file. Attached is a patch that should fix the problem.
WK> BTW - The known problem building under FreeBSD using BSD Make
WK> appears to be fixed (have tested on FreeSBD 2.2.5 and
WK> 3.0-current). I no longer need GNU Make or hack the Makefile
WK> by hand.
Cool! Thanks for the feedback -- I can only test with Solaris make and GNU make, so I'm glad my changes fixed the problem.
-Barry
Index: Utils.py
RCS file: /projects/cvsroot/mailman/Mailman/Utils.py,v retrieving revision 1.58 diff -c -r1.58 Utils.py *** Utils.py 1999/01/05 23:03:43 1.58 --- Utils.py 1999/01/06 23:05:03
*** 506,515 **** return got
! def chunkify(members, chunksize=mm_cfg.DEFAULT_ADMIN_MEMBER_CHUNKSIZE): """ return a list of lists of members """ members.sort() res = [] while 1: --- 506,517 ---- return got
! def chunkify(members, chunksize=None): """ return a list of lists of members """
if chunksize is None:
chunksize = mm_cfg.DEFAULT_ADMIN_MEMBER_CHUNKSIZE members.sort() res = [] while 1:
participants (2)
-
Barry A. Warsaw
-
Wayne Knowles