Re: [Mailman-Developers] logging patch for SMTPDirect.py

I filed bug 108167. I guess I'm not sure of the "patch" protocol; I could have posted a fix (I had one at the time I filed the bug). Sometimes I put it in the bug itself, although I didn't for this one, primarily because it was as much a "did you mean to leave this out?" question to Barry as anything.
But what's the story with patches? Is it just a "share this as you like" feature, as a convenient method of demonstrating the code to Barry et. al., or ?..
I guess what I'm asking is "Barry/Harald/other cabal-developers: do you want patches posted?..."
(and thanks for the patch; don't mean to sound ungrateful.)
I posted patch 100861 to sourceforge; this addresses bug 108167, which was the complaint that SMTPDirect.py didn't log posts to the post log like Sendmail.py did. Since the environment is a bit different (SMTPDirect can tell which user had what error, Sendmail just kind of worked or went Blooie) the "failure code" didn't seem to make sense; so I just had it log a successful attempt at doing smtp dialog, and ignore things that would just get the message thrown back into the queue; they'll likely show up in other logs anyway.
Mailman-Developers mailing list Mailman-Developers@python.org http://www.python.org/mailman/listinfo/mailman-developers

At 04:37 PM 7/11/00 -0700, Dan Mick wrote:
I filed bug 108167. I guess I'm not sure of the "patch" protocol; I could have posted a fix (I had one at the time I filed the bug). Sometimes I put it in the bug itself, although I didn't for this one, primarily because it was as much a "did you mean to leave this out?" question to Barry as anything.
But what's the story with patches? Is it just a "share this as you like" feature, as a convenient method of demonstrating the code to Barry et. al., or ?..
I guess what I'm asking is "Barry/Harald/other cabal-developers: do you want patches posted?..."
I've certainly been posting patches for broken things that I've found the solution to. In this case, I was perusing the bug list looking for things that I could fix, and submitted a patch for it...
participants (2)
-
Dan Mick
-
Ron Jarrell