There's a bug in the bounce processing in B4. I just upgraded my productio server (finally!) to mailman, and I'm getting these in the error log:
Jul 16 12:38:01 2000 qrunner(20080): Traceback (innermost last): Jul 16 12:38:01 2000 qrunner(20080): File "/home/mailman/cron/qrunner", line 2 09, in ? Jul 16 12:38:01 2000 qrunner(20080): kids = main(lock) Jul 16 12:38:01 2000 qrunner(20080): File "/home/mailman/cron/qrunner", line 1 78, in main Jul 16 12:38:01 2000 qrunner(20080): keepqueued = dispose_message(mlist, ms g, msgdata) Jul 16 12:38:01 2000 qrunner(20080): File "/home/mailman/cron/qrunner", line 6 8, in dispose_message Jul 16 12:38:01 2000 qrunner(20080): if BouncerAPI.ScanMessages(mlist, mime msg): Jul 16 12:38:01 2000 qrunner(20080): File "/home/mailman/Mailman/Bouncers/Boun cerAPI.py", line 54, in ScanMessages Jul 16 12:38:01 2000 qrunner(20080): addrs = func(msg) Jul 16 12:38:01 2000 qrunner(20080): File "/home/mailman/Mailman/Bouncers/DSN. py", line 109, in process Jul 16 12:38:01 2000 qrunner(20080): addrs.append(parseaddr(val)) Jul 16 12:38:01 2000 qrunner(20080): File "/home/mailman/Mailman/Bouncers/DSN. py", line 28, in parseaddr Jul 16 12:38:01 2000 qrunner(20080): atype, addr = string.split(val, ';') Jul 16 12:38:01 2000 qrunner(20080): ValueError : unpack list of wrong size
-- Chuq Von Rospach - Plaidworks Consulting (mailto:chuqui@plaidworks.com) Apple Mail List Gnome (mailto:chuq@apple.com)
And they sit at the bar and put bread in my jar and say 'Man, what are you doing here?'"
"CVR" == Chuq Von Rospach <chuqui@plaidworks.com> writes:
CVR> There's a bug in the bounce processing in B4. I just upgraded CVR> my productio server (finally!) to mailman, and I'm getting CVR> these in the error log: This can only happen if the bounce message has a bogus Original-Recipient: or Final-Recipient: header. If it's missing the address type field, the split will fail. In that case, I'm inclined not to guess at what the MTA was trying to say, and to return None, meaning we couldn't extract an address from the header. Attached is a patch, but it would still be great if you had a sample of the message that broke this so I could add it to my test suite. -Barry -------------------- snip snip -------------------- Index: DSN.py =================================================================== RCS file: /cvsroot/mailman/mailman/Mailman/Bouncers/DSN.py,v retrieving revision 1.5 diff -u -r1.5 DSN.py --- DSN.py 2000/06/08 03:44:38 1.5 +++ DSN.py 2000/07/17 21:59:54 @@ -25,7 +25,11 @@ def parseaddr(val): - atype, addr = string.split(val, ';') + try: + atype, addr = string.split(val, ';') + except ValueError: + # Bogus format for Original-Recipient: or Final-Recipient: fields + return None if string.lower(string.strip(atype)) <> 'rfc822': return None addr = string.strip(addr)
At 6:01 PM -0400 7/17/00, Barry A. Warsaw wrote:
meaning we couldn't extract an address from the header. Attached is a patch, but it would still be great if you had a sample of the message that broke this so I could add it to my test suite.
Okay, I'll add a hack to save messages and see what I can find.
-- Chuq Von Rospach - Plaidworks Consulting (mailto:chuqui@plaidworks.com) Apple Mail List Gnome (mailto:chuq@apple.com)
And they sit at the bar and put bread in my jar and say 'Man, what are you doing here?'"
participants (2)
-
bwarsaw＠beopen.com -
Chuq Von Rospach