Mailman 2.1.23 patch for MIME changes with headers or footers

Hi,
I hope this hits the right people (looking at some archives it seems to be, despite the list being mainly for MM3). Apologies if you consider it just noise.
I have a patch for Mailman 2.1.23 for MIME munging when there are no headers or footers. There is code to prevent this from happening but it wasn't happening for us.
The problem we saw occurred when a meeting request was created in Outlook and a mailing list was added as an invited recipient. Mailman would place MIME sections in a multipart which Outlook didn't recognice as a meeting request.
This patch simply allows whitespace-only headers and footers to be considered 'empty' so that the MIME structure is not altered in such cases. I suspect just testing for a single newline character would be enough, but I like to wear a belt and braces.
Iain

On 03/15/2017 09:37 AM, Fothergill, Iain wrote:
I hope this hits the right people (looking at some archives it seems to be, despite the list being mainly for MM3). Apologies if you consider it just noise.
I'm here. It probably would have been better to report this at <https://bugs.launchpad.net/mailman/+filebug>, but I have now done so <https://bugs.launchpad.net/mailman/+bug/1673307>
I have a patch for Mailman 2.1.23 for MIME munging when there are no headers or footers. There is code to prevent this from happening but it wasn't happening for us.
The problem we saw occurred when a meeting request was created in Outlook and a mailing list was added as an invited recipient. Mailman would place MIME sections in a multipart which Outlook didn't recognice as a meeting request.
You can avoid this issue by ensuring that msg_header and msg_footer are truly empty, but since this seems to come up occasionally, I'll fix it. I probably won't patch Decorate.py exactly as you have, but thanks for the hint.
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

On 03/15/2017 09:37 AM, Fothergill, Iain wrote:
I hope this hits the right people (looking at some archives it seems to be, despite the list being mainly for MM3). Apologies if you consider it just noise.
I'm here. It probably would have been better to report this at <https://bugs.launchpad.net/mailman/+filebug>, but I have now done so <https://bugs.launchpad.net/mailman/+bug/1673307>
I have a patch for Mailman 2.1.23 for MIME munging when there are no headers or footers. There is code to prevent this from happening but it wasn't happening for us.
The problem we saw occurred when a meeting request was created in Outlook and a mailing list was added as an invited recipient. Mailman would place MIME sections in a multipart which Outlook didn't recognice as a meeting request.
You can avoid this issue by ensuring that msg_header and msg_footer are truly empty, but since this seems to come up occasionally, I'll fix it. I probably won't patch Decorate.py exactly as you have, but thanks for the hint.
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
participants (2)
-
Fothergill, Iain
-
Mark Sapiro