GetScriptURL and "absolute=1"
Hi,
I still find that mailman's administrative interface behaves incorrectly on HTTPDs running on non-standard ports. It simply discards the port information out of the URL, despite DEFAULT_URL* settings.
On some pages, the URL to the FORM ACTION is relative (eg, the "General Options" form) while others, it is absolute (eg, the "Membership list").
Looking around the source, I've found lines like this
adminurl = mlist.GetScriptURL('admin', absolute=1)
Changing the value of ABSOLUTE to 0 solved the problem, and I've found it pretty harmless. Any specific reason for the ABSOLUTE=1 setting? If this is okay, I can provide a patch (although there are very few lines that need changing).
Thanks, Fabricio Chalub
"FC" == Fabricio Chalub <CHALUB@fgv.br> writes:
FC> I still find that mailman's administrative interface behaves
FC> incorrectly on HTTPDs running on non-standard ports. It
FC> simply discards the port information out of the URL, despite
FC> DEFAULT_URL* settings.Remember that these variables have no effect on already existing lists. They only affect the base urls for new lists. If you want to change the base url, e.g. to make sure it's got the port number, use bin/fix_url.py.
FC> Looking around the source, I've found lines like this
FC> adminurl = mlist.GetScriptURL('admin', absolute=1)
FC> Changing the value of ABSOLUTE to 0 solved the problem, and
FC> I've found it pretty harmless. Any specific reason for the
FC> ABSOLUTE=1 setting? If this is okay, I can provide a patch
FC> (although there are very few lines that need changing).Eventually, the `absolute' argument is going to be removed, and all urls will be absolute (or more correctly, all calls to GetScriptURL() will return absolute urls). Relative urls are too problematic.
-Barry
participants (2)
-
barry＠python.org -
Fabricio Chalub