This happened twice on sf.net about 12H after the upgrade to 2.0.9
Apr 09 02:28:06 2002 usw-sf-list1 qrunner(9416): Traceback (most recent call las t): Apr 09 02:28:06 2002 usw-sf-list1 qrunner(9416): File "/var/local/mailman/cron /qrunner", line 282, in ? Apr 09 02:28:06 2002 usw-sf-list1 qrunner(9416): kids = main(lock) Apr 09 02:28:06 2002 usw-sf-list1 qrunner(9416): File "/var/local/mailman/cron /qrunner", line 204, in main Apr 09 02:28:06 2002 usw-sf-list1 qrunner(9416): os.unlink(root+'.msg') Apr 09 02:28:06 2002 usw-sf-list1 qrunner(9416): OSError : [Errno 2] No such fi le or directory: '/var/local/mailman/qfiles/c0cd07c04a0599fb40d2251f364aa2d187fc af43.msg.msg'
Note the ".msg.msg" (I am not claiming it's new to 2.0.9, I have to admit that my old error log file was getting too big for me to read it)
There are also fun ones like: Apr 09 08:48:47 2002 usw-sf-list1 (517) Exception while calculating message head er: unsupported format character '^M' (0xd) at index 87
or Apr 09 06:35:04 2002 usw-sf-list1 (17060) NNTP gateway improperly configured: no newsgroup, no NNTP host
(there aren't new mind you, and I think Barry said that mm2.1 was better about telling you which list these errors happened in)
Marc
Microsoft is to operating systems & security .... .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | Finger marc_f@merlins.org for PGP key
"MM" == Marc MERLIN <marc_news@vasoftware.com> writes:
MM> This happened twice on sf.net about 12H after the upgrade to MM> 2.0.9 MM> Apr 09 02:28:06 2002 usw-sf-list1 qrunner(9416): Traceback MM> (most recent call las t): Apr 09 02:28:06 2002 usw-sf-list1 MM> qrunner(9416): File "/var/local/mailman/cron /qrunner", line MM> 282, in ? Apr 09 02:28:06 2002 usw-sf-list1 qrunner(9416): MM> kids = main(lock) Apr 09 02:28:06 2002 usw-sf-list1 MM> qrunner(9416): File "/var/local/mailman/cron /qrunner", line MM> 204, in main Apr 09 02:28:06 2002 usw-sf-list1 qrunner(9416): MM> os.unlink(root+'.msg') Apr 09 02:28:06 2002 usw-sf-list1 MM> qrunner(9416): OSError : [Errno 2] No such fi le or directory: MM> '/var/local/mailman/qfiles/c0cd07c04a0599fb40d2251f364aa2d187fc MM> af43.msg.msg' MM> Note the ".msg.msg" (I am not claiming it's new to 2.0.9, I MM> have to admit that my old error log file was getting too big MM> for me to read it) Arrgghh! Can you say MM2.0.10? :( Message.Enqueue() writes a .msg.tmp file and there's a small window of opportunity for qrunner to see that file before it's flipped over to just .msg. qrunner's main needs to be taught to ignore .tmp files. See attached patch. MM> There are also fun ones like: Apr 09 08:48:47 2002 MM> usw-sf-list1 (517) Exception while calculating message head MM> er: unsupported format character '^M' (0xd) at index 87 MM> or Apr 09 06:35:04 2002 usw-sf-list1 (17060) NNTP gateway MM> improperly configured: no newsgroup, no NNTP host MM> (there aren't new mind you, and I think Barry said that mm2.1 MM> was better about telling you which list these errors happened MM> in) It should be. The first one is because somebody's got something bogus in their message header, the second because they've enabled gatewaying but the never set up an NNTP host. -Barry Index: qrunner =================================================================== RCS file: /cvsroot/mailman/mailman/cron/Attic/qrunner,v retrieving revision 1.18.2.4 diff -u -r1.18.2.4 qrunner --- qrunner 2 Apr 2002 22:38:50 -0000 1.18.2.4 +++ qrunner 9 Apr 2002 20:44:27 -0000 @@ -194,10 +194,11 @@ # Keep the qrunner lock alive for a while longer lock.refresh() root, ext = os.path.splitext(os.path.join(mm_cfg.QUEUE_DIR, file)) - if ext == '.db': + if ext == '.db' or ext == '.tmp': # Just trigger off the .msg files. This may leave stale .db files # in qfiles, but these can't be cleaned up without storing a - # timestamp and watching out for race conditions. + # timestamp and watching out for race conditions. .tmp files are + # created by Message.Enqueue() and are fleeting. continue if not os.path.exists(root+'.db'): syslog('qrunner', 'Unlinking orphaned .msg file: %s.msg' % root)
On Tue, Apr 09, 2002 at 04:44:48PM -0400, Barry A. Warsaw wrote:
Arrgghh! Can you say MM2.0.10? :(
Sorry.
See attached patch.
Applied, thanks.
It should be. The first one is because somebody's got something bogus in their message header, the second because they've enabled gatewaying but the never set up an NNTP host.
Oh, I know, the messages make sense, I'll just have to patch the code to find out which list they actually occur in :-)
Marc
Microsoft is to operating systems & security .... .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | Finger marc_f@merlins.org for PGP key
"MM" == Marc MERLIN <marc_news@vasoftware.com> writes:
>> Arrgghh! Can you say MM2.0.10? :(
MM> Sorry.Yeah, you'll get yours, one of these days. :)
>> See attached patch.
MM> Applied, thanks.Can you keep an eye on the log files for a few days? I'm going to apply the same patch on python.org and watch it there too. If all looks good for a few days I'll release an update.
Sigh. -Barry
On Tue, Apr 09, 2002 at 05:03:48PM -0400, Barry A. Warsaw wrote:
>> See attached patch.
MM> Applied, thanks.
Can you keep an eye on the log files for a few days? I'm going to apply the same patch on python.org and watch it there too. If all looks good for a few days I'll release an update.
Will do. So we are now running X-Mailman-Version: 2.0.9-sf.net Since I'm working on sf.net mailman anyway, I also wipped up the following (very very dirty) quick patch: diff -urN mailman-2.0.9.sf/Mailman/Handlers/Decorate.py mailman-2.0.9.sf.new/Mailman/Handlers/Decorate.py --- mailman-2.0.9.sf/Mailman/Handlers/Decorate.py Wed Aug 29 11:38:17 2001 +++ mailman-2.0.9.sf.new/Mailman/Handlers/Decorate.py Tue Apr 9 14:01:42 2002 @@ -38,12 +38,12 @@ try: header = string.replace(mlist.msg_header % d, '\r\n', '\n') except (ValueError, TypeError), e: - syslog('error', 'Exception while calculating message header:\n%s' % e) + syslog('error', 'Exception while calculating message header in list '+mlist.internal_name()+':\n%s' % e) header = '[INVALID HEADER]' try: footer = string.replace(mlist.msg_footer % d, '\r\n', '\n') except (ValueError, TypeError), e: - syslog('error', 'Exception while calculating message footer:\n%s' % e) + syslog('error', 'Exception while calculating message footer in list '+mlist.internal_name()+':\n%s' % e) footer = '[INVALID FOOTER]' msg.body = header + msg.body + footer # Mark the message as dirty so that its text will be forced to disk next diff -urN mailman-2.0.9.sf/Mailman/Handlers/ToUsenet.py mailman-2.0.9.sf.new/Mailman/Handlers/ToUsenet.py --- mailman-2.0.9.sf/Mailman/Handlers/ToUsenet.py Mon Nov 5 20:31:47 2001 +++ mailman-2.0.9.sf.new/Mailman/Handlers/ToUsenet.py Tue Apr 9 13:57:12 2002 @@ -44,8 +44,7 @@ if not mlist.nntp_host: error.append('no NNTP host') if error: - syslog('error', 'NNTP gateway improperly configured: ' + - string.join(error, ', ')) + syslog('error', 'NNTP gateway in list '+mlist.internal_name()+' improperly configured: ' + string.join(error, ', ')) return # Fork in case the nntp connection hangs. pid = os.fork() -- Microsoft is to operating systems & security .... .... what McDonalds is to gourmet cooking Home page: http://marc.merlins.org/ | Finger marc_f@merlins.org for PGP key
On Tue, Apr 09, 2002 at 05:03:48PM -0400, Barry A. Warsaw wrote:
MM> Applied, thanks.Can you keep an eye on the log files for a few days? I'm going to apply the same patch on python.org and watch it there too. If all looks good for a few days I'll release an update.
No errors so far, it looks good. I'll be off (racing) tomorrow so if you want to wait that long, I can give you another update friday, but right now it definitely looks better.
Marc
Microsoft is to operating systems & security .... .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | Finger marc_f@merlins.org for PGP key
"MM" == Marc MERLIN <marc_news@vasoftware.com> writes:
MM> No errors so far, it looks good. I'll be off (racing)
MM> tomorrow so if you want to wait that long, I can give you
MM> another update friday, but right now it definitely looks
MM> better.Cool, thanks! I probably won't get to the release until Friday anyway.
Have fun, -Barry
participants (2)
-
barry＠zope.com -
Marc MERLIN