Bouncer.py syslog differences
Hello. The following is portion of an exchange of ideas between Mark Sapiro and myself (initial comments) which occurred not too long ago on this list:
As a minor side note, I noticed the bounce log receives two different formatted messages for the first bounce and subsequent bounces. An example: ... Oct 25 10:50:51 2005 (2687) samplelist: falseaddresstest@somedomain.net bounce score: 1.0 Oct 25 11:06:54 2005 (2687) falseaddresstest@somedomain.net: samplelist current bounce score: 2.0 ... This is not a major issue but it is inconsistent and it not clear why it should be this way. Is there reason is should be different?
I don't think so. All the other log messages from Bouncer are "list: member". I don't see any reason why this one shouldn't also be that way.
OK. Should this be entered as a bug on SF?
Yes, I think so, but I'd be inclined to wait a bit and see if there are more comments from the list.
It does not appear that more comments have been made on this issue. I am trying to work with the output of the Mailman logs (Brad Knowles has a great script <http://sourceforge.net/tracker/index.php?func=detail&aid=1123383&group_id=103&atid=300103> for this but, it would be preferred to store more information in a database for reporting- not sure the best way to do this yet) and this minor difference is slightly annoying. Additionally, as Mark noted, no reason has been given to explain difference from other "current bounce score" messages. Here is a patch that should correct this difference: --- Bouncer.py.10.25.2005.original 2005-10-25 12:21:57.000000000 -0400 +++ Bouncer.py.log.patch 2005-11-11 11:27:08.000000000 -0500 @@ -145,7 +145,7 @@ info.score += weight info.date = day syslog('bounce', '%s: %s current bounce score: %s', - member, self.internal_name(), info.score) + self.internal_name(), member, info.score) # Continue to the check phase below # # Now that we've adjusted the bounce score for this bounce, let's Unless there is a case against filing this as a bug on SourceForge, I'm willing to file one within the next couple weeks. -Adrian
Adrian Wells wrote:
It does not appear that more comments have been made on this issue. I am trying to work with the output of the Mailman logs (Brad Knowles has a great script <http://sourceforge.net/tracker/index.php?func=detail&aid=1123383&group_id=103&atid=300103> for this but, it would be preferred to store more information in a database for reporting- not sure the best way to do this yet) and this minor difference is slightly annoying. Additionally, as Mark noted, no reason has been given to explain difference from other "current bounce score" messages. Here is a patch that should correct this difference:
--- Bouncer.py.10.25.2005.original 2005-10-25 12:21:57.000000000 -0400 +++ Bouncer.py.log.patch 2005-11-11 11:27:08.000000000 -0500 @@ -145,7 +145,7 @@ info.score += weight info.date = day syslog('bounce', '%s: %s current bounce score: %s', - member, self.internal_name(), info.score) + self.internal_name(), member, info.score) # Continue to the check phase below # # Now that we've adjusted the bounce score for this bounce, let's
Unless there is a case against filing this as a bug on SourceForge, I'm willing to file one within the next couple weeks.
The above patch has been committed to CVS. -- Mark Sapiro <msapiro@value.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
Mark Sapiro <msapiro@value.net> on Tuesday, December 06, 2005 at 4:18 PM +0000 wrote:
Adrian Wells wrote:
Unless there is a case against filing this as a bug on SourceForge, I'm willing to file one within the next couple weeks.
The above patch has been committed to CVS.
Thank you. I had not yet taken the time to submit a bug report to SourceForge and imagine there is no reason to do so now.
-Adrian
participants (2)
-
Adrian Wells -
Mark Sapiro