a patch: init script cleanup for LSB compliance

hello,
There's an effort in Fedora to improve all our init scripts for better LSB compliance. Because I'm responsible for mailman package here, I made following changes in the mailman init scripts:
when mailman is unconfigured, `service mailman start' should exit with code 6, not 1.
`try-restart' was't implemented. This is an addition to condrestart and should have the same effect.
stopping mailman when already stopped doesn't print scary error message now, prints "mailman already stopped" instead
when /var/lock/subsys/mailman exists but mailman isn't running, and `service mailman status' was executed, the script just printed 'mailman is stopped' and exited with code 3. In this case, it should say that it's dead but its subsys is locked, and exit with code 2.
when no known parameter is passed to the init script, it should exit with code 2, not 3.
patch attached, references:
http://refspecs.freestandards.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generi... (Linux Standard Base init scripts specification)
https://bugzilla.redhat.com/show_bug.cgi?id=524016 (Red Hat bugzilla entry addressing mailman init scripts)
best regards,
Daniel Novotny, Red Hat inc.
participants (1)
-
Daniel Novotny