Hyperkitty MR Feedback - Hiding private lists from index
I'm hoping for some feedback a MR I submitted for hyperkitty a few days ago: https://gitlab.com/mailman/hyperkitty/merge_requests/110
My initial goal was just to make it possible to hide private lists from the index for users who don't have access. However I expanded the scope a bit to also show private lists when sorting by popularity and activity IF the user is subscribed (currently all private lists are hidden from those views for all users).
In the MR the behavior is enabled via a Django setting and is off by default. This mostly preserves the existing behavior, except I did make it such that superusers always see all lists. It occurred to me though that it may be desirable to have the "new" behavior be the default from a user experience perspective. Anyway, I just wanted to get some feedback on the approach as this is my first MR against mailman.
Thanks! -Jake
participants (1)
-
Jake Scaltreto