Re: [Mailman-Developers] [Mailman-checkins] [Branch ~mailman-coders/mailman/3.0] (no title)

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Mark, thanks for fixing this. Just a couple of quick comments... On Jun 28, 2007, at 1:27 PM, noreply@launchpad.net wrote:
This is probably better style: if path == private or ( os.path.commonprefix((path, private)) == private and os.path.split(path)[1] == 'database'): # then... targetperms = PRIVATEPERMS It eliminates a backslash (always ugly ;) though it kind of begs for the 'then...' comment because of the way the columns line up.
Similarly, this removes the need for a backslash: elif (os.path.commonprefix((path, config.QUEUE_DIR)) == config.QUEUE_DIR): targetperms = QFILEPERMS You probably can't do much better without storing config.QUEUE_DIR in a local variable. Cheers, - -Barry -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iQCVAwUBRoP6mHEjvBPtnXfVAQL8qQP9GZzd1T5xdGGmcWvGR+lpZPUpZPGWJhCq 7yH54o8E45pBisH6LVVJR3KoS7/xfJGevj3t/tQ6gLgiOsdeiLaTWQJ05UBBiHAr r8+7FWWgUrc84o7EvkhgXXsqCVT/iFTW1yVWmlsVGLm0ezdl6oOPTcrpJ2biA63S 3Hn//tQKi2o= =rA0r -----END PGP SIGNATURE-----

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Barry Warsaw wrote:
Hi Mark, thanks for fixing this. Just a couple of quick comments...
Thanks Barry,
I thought about this a bit, but clearly didn't think it through. I'll clean it up.
/Mark
Mark Sapiro <msapiro@value.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32)
iD8DBQFGg/5NVVuXXpU7hpMRAguhAJ9X9PpO8yhZqQ40vi5cfjCKCnmodQCg7/Ph GQxqjG/MfwJWFZYflqvaTnI= =EWWb -----END PGP SIGNATURE-----

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Jun 28, 2007, at 2:30 PM, Mark Sapiro wrote:
Thanks Mark!
- -Barry
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin)
iQCVAwUBRoQAkXEjvBPtnXfVAQLbSwP+IKkeaLWQ08+tR61ZRAJ3HBghGcIclQiB xUjVlrS4KZ+eljtxRD55VCFGgvZ0SzOUlC9MZQBR3k7Dy901dGj24Pm1ZJE0fCYN FmEvhf/Oaw0JMebYY8itI9AxBuIFGOcWcd1qfdiZ29Gg1yxB2ri7Ah6S4zKwCO0N asw3oOfLWwo= =t8Tv -----END PGP SIGNATURE-----

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Barry Warsaw wrote:
Hi Mark, thanks for fixing this. Just a couple of quick comments...
Thanks Barry,
I thought about this a bit, but clearly didn't think it through. I'll clean it up.
/Mark
Mark Sapiro <msapiro@value.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32)
iD8DBQFGg/5NVVuXXpU7hpMRAguhAJ9X9PpO8yhZqQ40vi5cfjCKCnmodQCg7/Ph GQxqjG/MfwJWFZYflqvaTnI= =EWWb -----END PGP SIGNATURE-----

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Jun 28, 2007, at 2:30 PM, Mark Sapiro wrote:
Thanks Mark!
- -Barry
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin)
iQCVAwUBRoQAkXEjvBPtnXfVAQLbSwP+IKkeaLWQ08+tR61ZRAJ3HBghGcIclQiB xUjVlrS4KZ+eljtxRD55VCFGgvZ0SzOUlC9MZQBR3k7Dy901dGj24Pm1ZJE0fCYN FmEvhf/Oaw0JMebYY8itI9AxBuIFGOcWcd1qfdiZ29Gg1yxB2ri7Ah6S4zKwCO0N asw3oOfLWwo= =t8Tv -----END PGP SIGNATURE-----
participants (2)
-
Barry Warsaw
-
Mark Sapiro