oops - hit a bug - 1.0b11
just noticed this in my logs from this afternoon - don't know if it's b11 specific... I am able to reproduce the problem by: 1. go to listinfo page 2. hit link for archive (archive restricted to members) 3. enter aaa@bbb.com for user ( any non member ) 4. enter 12345 (or anything else for password) then I get the "oops" page... I don't recall trying to access a restricted archive as a non-member before this, so it may not be b11 specific. I assume private.py should also be trapping the MMNotAMemberError error... -Jeff Apr 03 18:04:13 1999 admin: @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ admin: [----- Mailman Version: 1.0b11 -----] admin: [----- Traceback ------] admin: Traceback (innermost last): admin: File "/home/mailman/MM/scripts/driver", line 112, in run_main admin: main() admin: File "/home/mailman/MM/Mailman/Cgi/private.py", line 163, in main admin: if not list_name or not isAuthenticated(list_name): admin: File "/home/mailman/MM/Mailman/Cgi/private.py", line 120, in isAuthenticated admin: listobj.ConfirmUserPassword( username, password) admin: File "/home/mailman/MM/Mailman/SecurityManager.py", line 76, in ConfirmUserPassword admin: raise Errors.MMNotAMemberError admin: MMNotAMemberError
"JH" == Jeff Hahn <jeffh@streek.com> writes:
JH> just noticed this in my logs from this afternoon - don't know
JH> if it's b11 specific...
JH> I am able to reproduce the problem by:
| 1. go to listinfo page
| 2. hit link for archive (archive restricted to members)
| 3. enter aaa@bbb.com for user ( any non member )
| 4. enter 12345 (or anything else for password)
JH> then I get the "oops" page... I don't recall trying to access
JH> a restricted archive as a non-member before this, so it may
JH> not be b11 specific. I assume private.py should also be
JH> trapping the MMNotAMemberError error...Correct. Here's a patch, thanks for the report! -Barry
-------------------- snip snip -------------------- Index: private.py
RCS file: /projects/cvsroot/mailman/Mailman/Cgi/private.py,v retrieving revision 1.11 retrieving revision 1.12 diff -c -r1.11 -r1.12 *** private.py 1999/03/29 23:53:57 1.11 --- private.py 1999/04/04 02:06:58 1.12
*** 118,124 **** raise SystemExit try: listobj.ConfirmUserPassword( username, password) ! except (Errors.MMBadUserError, Errors.MMBadPasswordError): return 0
token = `hash(list_name)`--- 118,125 ---- raise SystemExit try: listobj.ConfirmUserPassword( username, password) ! except (Errors.MMBadUserError, Errors.MMBadPasswordError, ! Errors.MMNotAMemberError): return 0
token = `hash(list_name)`
participants (2)
-
Barry A. Warsaw -
Jeff Hahn