Hello,
I have created my proposal for GSoD'19. It would be really helpful if you can go through it and provide your feedback. ( https://docs.google.com/document/d/1H-h2_TFDAl_o8c0WeT60OkeZedcDicGIPripaVMh... )
Also, I found a small typo error/ spelling mistake in the documentation. The word relevant is spelled wrong. https://postorius.readthedocs.io/en/latest/development.html#view-authorizati...
Thank You, Aditi
ᐧ
Hi Abhilash,
I have opened an issue https://gitlab.com/aditigupta96/postorius/issues/1 for this. Please have a look at it.
Thanks, Aditi ᐧ
On Sun, Jun 9, 2019 at 9:22 PM Abhilash Raj <maxking@asynchronous.in> wrote:
On Sun, Jun 9, 2019, at 9:04 AM, ADITI GUPTA wrote:
Hi Abhilash,
I have opened an issue https://gitlab.com/aditigupta96/postorius/issues/1 for this. Please have a look at it.
Thanks!
-- thanks, Abhilash Raj (maxking)
Hi Aditi,
Thanks for the report. You might be aware that you are opening the issue in your owned fork, which we may not be able to notice quickly. Please open issues and merge requests under the mailman org ( https://gitlab.com/mailman/postorius/issues for example). (Note: merge request and pull request are one thing with two different names on GitLab and GitHub namely).
Just as Abhilash said, you are more welcome to open a merge request like this (https://gitlab.com/mailman/postorius/merge_requests/420/diffs). To do so, you will need to
- Locally clone your forked repo.
- Use any editor you like - I use vscode - to edit the mentioned file. In this case, /src/postorius/doc/development.rst.
- Commit the file and push to your fork.
- Create a merge request on the repo under mailman org - you will also get a notice when you push.
- (Optional) Tell us your request on IRC.
Maybe it is your first time using git as version control, but it is a good start for your GSoD road. If you are going to change lots of things under different repos - for example mailman core and postorius - you will need to do the thing above twice on two repos.
Check here for git beginner tutorials:
- https://rogerdudler.github.io/git-guide/ - recommended as it is organised in a funny webpage.
- https://docs.gitlab.com/ee/gitlab-basics/start-using-git.html
Hope this clarify the process.
For the proposal, I am commenting on the doc. Enjoy your GSoD :)
Yours truly, Xiaoxing Ye
On Mon, Jun 10, 2019 at 12:06 AM ADITI GUPTA <aditi.medha96@gmail.com> wrote:
Hi,
Thank you Xiaoxing for noticing. I might have done it by mistake. I have opened the issue under the mailman org ( https://gitlab.com/mailman/postorius/issues/367). Please have a look at it.
Also, thank you for going through my proposal :)
Thanks, Aditi ᐧ
On Sun, Jun 9, 2019 at 10:16 PM Abhilash Raj <maxking@asynchronous.in> wrote:
Hi Abhilash,
I have opened an issue https://gitlab.com/aditigupta96/postorius/issues/1 for this. Please have a look at it.
Thanks, Aditi ᐧ
On Sun, Jun 9, 2019 at 9:22 PM Abhilash Raj <maxking@asynchronous.in> wrote:
On Sun, Jun 9, 2019, at 9:04 AM, ADITI GUPTA wrote:
Hi Abhilash,
I have opened an issue https://gitlab.com/aditigupta96/postorius/issues/1 for this. Please have a look at it.
Thanks!
-- thanks, Abhilash Raj (maxking)
Hi Aditi,
Thanks for the report. You might be aware that you are opening the issue in your owned fork, which we may not be able to notice quickly. Please open issues and merge requests under the mailman org ( https://gitlab.com/mailman/postorius/issues for example). (Note: merge request and pull request are one thing with two different names on GitLab and GitHub namely).
Just as Abhilash said, you are more welcome to open a merge request like this (https://gitlab.com/mailman/postorius/merge_requests/420/diffs). To do so, you will need to
- Locally clone your forked repo.
- Use any editor you like - I use vscode - to edit the mentioned file. In this case, /src/postorius/doc/development.rst.
- Commit the file and push to your fork.
- Create a merge request on the repo under mailman org - you will also get a notice when you push.
- (Optional) Tell us your request on IRC.
Maybe it is your first time using git as version control, but it is a good start for your GSoD road. If you are going to change lots of things under different repos - for example mailman core and postorius - you will need to do the thing above twice on two repos.
Check here for git beginner tutorials:
- https://rogerdudler.github.io/git-guide/ - recommended as it is organised in a funny webpage.
- https://docs.gitlab.com/ee/gitlab-basics/start-using-git.html
Hope this clarify the process.
For the proposal, I am commenting on the doc. Enjoy your GSoD :)
Yours truly, Xiaoxing Ye
On Mon, Jun 10, 2019 at 12:06 AM ADITI GUPTA <aditi.medha96@gmail.com> wrote:
Hi,
Thank you Xiaoxing for noticing. I might have done it by mistake. I have opened the issue under the mailman org ( https://gitlab.com/mailman/postorius/issues/367). Please have a look at it.
Also, thank you for going through my proposal :)
Thanks, Aditi ᐧ
On Sun, Jun 9, 2019 at 10:16 PM Abhilash Raj <maxking@asynchronous.in> wrote:
participants (3)
-
Abhilash Raj -
ADITI GUPTA -
Xiaoxing Ye