Problem with new configuration.Configuration.load()
If the new configuration.Configuration.load() method is given a configuration file argument which is a non-existent file, it will silently fall back to loading mm_cfg.py.
I think it should remember whether a filename argument is passed and complain if the passed file doesn't exist.
-- Mark Sapiro <msapiro@value.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
Mark Sapiro wrote:
If the new configuration.Configuration.load() method is given a configuration file argument which is a non-existent file, it will silently fall back to loading mm_cfg.py.
I think it should remember whether a filename argument is passed and complain if the passed file doesn't exist.
+1
BTW, should we all move to new config sheme ? Then, should we make some upgrade script in Mailman/versions.py ?
-- Tokio Kikuchi, tkikuchi@is.kochi-u.ac.jp http://weather.is.kochi-u.ac.jp/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Oct 21, 2006, at 8:29 PM, Tokio Kikuchi wrote:
Mark Sapiro wrote:
If the new configuration.Configuration.load() method is given a configuration file argument which is a non-existent file, it will silently fall back to loading mm_cfg.py.
I think it should remember whether a filename argument is passed and complain if the passed file doesn't exist.
+1
BTW, should we all move to new config sheme ? Then, should we make
some upgrade script in Mailman/versions.py ?
So one question is whether we should continue to support mm_cfg.py
for Mailman 2.2. Originally I thought we should for backward
compatibility. Tokio, are you suggesting that we move a MM2.1
mm_cfg.py to etc/mailman.cfg during the upgrade?
If we do that, then we can just eradicate mm_cfg.py altogether.
Otherwise, if we decide to keep mm_cfg.py for backward compatibility,
I do think we ought to complain if a file is passed in that doesn't
exist. I wasn't sure we should do the complaining in .load(), but
since those are only every called from bin scripts, I think that's
probably fine.
- -Barry
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin)
iQCVAwUBRTvmenEjvBPtnXfVAQJhSgP/ZgIaDWPDCvEWecYNPgNyU3RTbqco7xp/ gycUe0kyo0MFqmuRcJd/HDYqar5JaLIPSRYhNM8b5w8OgdrL5sJGJX1eOTiuv0sb TSr2jiJHnnGIXZyNRj2Q2HDZw4yURBbrT0S8eaTtaxe2P2V0N8udmyRgfem1lynk bAREAHkUaUY= =hidD -----END PGP SIGNATURE-----
+1 on the idea of etc/mailman.cfg. Would be nice also to have some sample file of all configurable parms, or at least a doc of it.
---------- Original Message ----------- From: Barry Warsaw <barry@python.org> To: Tokio Kikuchi <tkikuchi@is.kochi-u.ac.jp> Cc: Mailman Developers <mailman-developers@python.org> Sent: Sun, 22 Oct 2006 17:45:29 -0400 Subject: Re: [Mailman-Developers] Problem with new configuration.Configuration.load()
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Oct 21, 2006, at 8:29 PM, Tokio Kikuchi wrote:
Mark Sapiro wrote:
If the new configuration.Configuration.load() method is given a configuration file argument which is a non-existent file, it will silently fall back to loading mm_cfg.py.
I think it should remember whether a filename argument is passed and complain if the passed file doesn't exist.
+1
BTW, should we all move to new config sheme ? Then, should we make
some upgrade script in Mailman/versions.py ?So one question is whether we should continue to support mm_cfg.py
for Mailman 2.2. Originally I thought we should for backward
compatibility. Tokio, are you suggesting that we move a MM2.1
mm_cfg.py to etc/mailman.cfg during the upgrade?If we do that, then we can just eradicate mm_cfg.py altogether.
Otherwise, if we decide to keep mm_cfg.py for backward compatibility, I do think we ought to complain if a file is passed in that doesn't exist. I wasn't sure we should do the complaining in .load(), but since those are only every called from bin scripts, I think that's probably fine.
- -Barry
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin)
iQCVAwUBRTvmenEjvBPtnXfVAQJhSgP/ZgIaDWPDCvEWecYNPgNyU3RTbqco7xp/ gycUe0kyo0MFqmuRcJd/HDYqar5JaLIPSRYhNM8b5w8OgdrL5sJGJX1eOTiuv0sb TSr2jiJHnnGIXZyNRj2Q2HDZw4yURBbrT0S8eaTtaxe2P2V0N8udmyRgfem1lynk bAREAHkUaUY= =hidD -----END PGP SIGNATURE-----
Mailman-Developers mailing list Mailman-Developers@python.org http://mail.python.org/mailman/listinfo/mailman-developers Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py Searchable Archives: http://www.mail-archive.com/mailman-developers%40python.org/ Unsubscribe: http://mail.python.org/mailman/options/mailman-developers/bob%40nleaudio.com
Security Policy: http://www.python.org/cgi-bin/faqw-mm.py?req=show&file=faq01.027.htp ------- End of Original Message -------
participants (4)
-
Barry Warsaw -
Bob Puff -
Mark Sapiro -
Tokio Kikuchi